Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipes - Rebecca - JS - Scrabble #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

rbergena
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? I was able to translate a few different concepts into the JS version of scrabble (e.g., loops, conditionals, and classes).
What was a challenge you were able to overcome on this assignment? I was able to figure out some debugging challenges.
What is your favorite thing about learning a new programming language? Being able to apply concepts from a previous language in new ways.
What is your least favorite thing about learning a new programming language? It can be hard to transition from one language's syntax to another language's syntax.
Do you have any recommendations on how we could improve this project for the next cohort? Maybe focus a bit more on design and organization of code in JS versus Ruby.

@droberts-sea
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene could be better - even on a small project like this, it's important to break your work up into small, well-defined chunks
Comprehension questions yes
General
score calculates score, has appropriate params and return value yes
highestScoreFrom calculates highest scoring word, has appropriate params and return value yes
Player object
Has name and plays properties yes
Has play, totalScore, hasWon functions yes
Has highestScoringWord and highestWordScore functions yes
Overall Great work overall!


tie: function tie(word, maxWord) {
if (((word.length === 7) && (maxWord.length !== 7)) || ((word.length < maxWord.length) && (maxWord.length !== 7))) {
maxWord = word;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of a helper function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants