Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carets - Maria - js-scrabble #25

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Carets - Maria - js-scrabble #25

wants to merge 25 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 17, 2017

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? I was able to use the pattern of building functions that call on other functions, like we did in Ruby. I did this with the totalScore and hasWon function.
What was a challenge you were able to overcome on this assignment? Figuring out where to begin with the letterScores object. For some reason took me some time to wrap my head around it being used like a hash, but once I did that I just used some basic logic to get the word scored and then continue the assignment from there.
What is your favorite thing about learning a new programming language? I like finding the similarities between the new language and a language I've already learned.
What is your least favorite thing about learning a new programming language? The time it takes to research comparable things to other languages such as enumerables. I went back to what felt like very basic and clunky code with my highestScoreFrom function because I used an enumerable in the Ruby version of Scrabble, but wan't sure how to approach reduce in this assignment quite yet and didn't want to take up too much time and then get behind, so I just made it work with lots of lines of code...
Do you have any recommendations on how we could improve this project for the next cohort? Not particularly. I think the in-class exercises and worksheets that we did throughout lecture were incredibly helpful in preparing for this assignment. I also think it would've been neat to have tests for the optional tileBag. The tests helped guide me for the 2 waves, but when I tried tileBag and tried duplicating the tests in order to do tileBag I just made it a mess and ended up eliminating it.

@CheezItMan
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commit and commit messages
Comprehension questions I'm glad you worked out how to use the object like a hash. BTW there is a reduce function and others like .map. You could always research Jasmine and write your own tests...
General
score calculates score, has appropriate params and return value Check
highestScoreFrom calculates highest scoring word, has appropriate params and return value Check
Player object
Has name and plays properties Check
Has play, totalScore, hasWon functions Check
Has highestScoringWord and highestWordScore functions Check
Overall Nice work you hit all the requirements. You also did a good job taking the queues from the linter. The code is well done and elegant. I would suggest you take a look at the JavaScript Array functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants