Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carets- Julia Meier #29

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Carets- Julia Meier #29

wants to merge 8 commits into from

Conversation

julmeier
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? I was able to apply the same logic of loops and conditional statements, as well as calling other methods to DRY up code.
What was a challenge you were able to overcome on this assignment? I was having issues with understanding how the "return" works in JavaScript vs. in Ruby inside an anonymous function. I was able to figure out how to pass values to a variable that could return the value outside the inner anonymous function.
What is your favorite thing about learning a new programming language? I like how I start thinking through the logic in a different language, and "translate" in my head against other programming languages I've learned. After working on the project, I noticed that I almost wanted to put semicolons at the end of normal english sentences!
What is your least favorite thing about learning a new programming language? Knowing that there should be an easy way to do something you've done in another language but you just can't find the exact syntax.
Do you have any recommendations on how we could improve this project for the next cohort? I really enjoyed this assignment- I wouldn't recommend any changes.

@tildeee
Copy link

tildeee commented Nov 27, 2017

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
General
score calculates score, has appropriate params and return value x
highestScoreFrom calculates highest scoring word, has appropriate params and return value x
Player object
Has name and plays properties x
Has play, totalScore, hasWon functions x
Has highestScoringWord and highestWordScore functions x
Overall

For your function highestScoreFrom(words), you end up using two arrays bestWords and bestWordsLengths that you keep in parallel. I tend to recommend programmers to avoid that because it leads to so much possibility of forgetting to update one or the other appropriately. It would be better to find a different data structure that can handle keeping the two pieces of data together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants