Wenjie & Kat - Octos - Scrabble #5

kseastman · 2018-02-23T23:11:09Z

Scrabble

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature	Feedback
What are the advantages of using git when collaboratively working on one code base?	We can work independantly, and when we use git pull we can see the changes and decide which version handles the need better.
Why do you think we chose to make the `score` method in the `Scoring` class a class method instead of an instance method?	Because we never instantiate "Scoring" into a definite object, so it needs to be a class method, since it is functioning as a collection of methods, not as a discrete object.
Describe an example of a test you wrote for a nominal case.	In the Scoring class, we wrote a test to return the highest word if there were two words, this is nominal because it is making sure that code responds correctly to anticipated correct input.
Describe an example of a test you wrote for an edge case.	Using the Scoring class as an example, in the highest_score_From method, we wanted to test what would happen if the method was passed an empty array. This is not expected input, and therefore, it is an edge case.
Does your code use any methods from the `Enumerable` mixin? If so, where and why was it helpful?	We used max to get the highest scores, it was very useful because we did not have to write our own comparison method to find which score was higher by iterating through the hash.
What was one method you and your pair used to debug code?	We used awesome_print and pry to test the output of loops when we were getting results that were not what we expected.
Is there a specific piece of code you'd like feedback on?	The play word method in the Player class.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We learned a lot from working together, from methods and process to thinking about problems overall. We shared our opinions and listened to each other and tried really hard to work things out when we disagreed. We did a good job of breaking to spike so that we could have a reference for further conversation when deciding how to move forward.

…rtner Merge branch 'master' of https://github.com/kseastman/Scrabble

…t 7 letters or anything like that.

Add test parts for the method as well. Tested. Working as expected

…ow fails, refactoring code to pass.

- create constructor in TileBad class - create two methods: create_tiles and draw_tiles - create instance variable tiles_remaining

- Change all tiles to array of symbols

-Add a few in class Player -All tests for class Player passed

This test did not pass, need modify code

CheezItMan · 2018-03-02T00:34:39Z

Scrabble

What We're Looking For

Feature	Feedback
General
Answered comprehension questions	Check, I'm glad you two worked together well
Both Teammates contributed to the codebase	Both teammates have Commits
Regular Commits with meaningful commit messages	Good number of commits, but make the commit messages about the functionality added.
Scoring class
`score` method	Check
Uses appropriate data structure to store the letter score	Check, although it could be more compact.
Appropriately handles edge cases	Check
`highest_score_from` method	Check, well done!
Appropriately handles edge cases	Check
Test implementations for `highest_score_from`	Check, well done
Player class
Uses an array to keep track of words played	Check
Uses existing code to create `highest_scoring_word` and `highest_word_score`	Check
Returns `true` or `false` from `won?` method	Check
Tests edge cases on the `play(word)`	Check
TileBag class
Uses a data structure to keep the set of default tiles in the bag	Well done
`draw_tiles` method uses the parameter to draw a set of random tiles	Check
`tiles_remaining` method returns a count	Check
Tests `draw_tiles` edge cases	Check, good work testing the edge cases here. You are missing tests for the player `draw_tiles` method
Summary	Very nicely done, you hit all the learning objectives. Good work on testing edge-cases and good work with the `draw_tiles` and `highest_score_from` method.

CheezItMan · 2018-03-01T23:48:03Z

lib/scoring.rb

+        if !(letter =~ /[A-Z]/)
+          return nil
+        end
+        score += letter_score(letter)


Good use of a helper method.

CheezItMan · 2018-03-01T23:54:35Z

lib/scoring.rb

+      end
+
+      if max_keys.length == 1
+        return word_score.key(word_score.values.max)


This is a little awkward. since there is only one max word score, you could return, max_keys.first

CheezItMan · 2018-03-01T23:55:50Z

lib/tile_bag.rb

+
+      letter_quantity.each do |letter, quantity|
+        quantity.times do
+          tiles << Scrabble::Tile.new(letter)


Good choice putting the tiles into an array like this

CheezItMan · 2018-03-02T00:12:54Z

lib/tile_bag.rb

+
+  end
+
+  class Tile


Think about POODR, don't write an additional class unless you need to. This class really isn't doing anything more than a 1-letter string.

CheezItMan · 2018-03-02T00:14:15Z

lib/player.rb

+
+        plays << word
+        score = Scrabble::Scoring.score(word)
+        self.total_score += score


This totally works, but you might consider making total_score a calculated field (a method) instead of an instance variable.

CheezItMan · 2018-03-02T00:28:45Z

specs/tile_bag_spec.rb

+
+      # Assert
+      result.length.must_equal 7
+      result.wont_equal [:A, :A, :A, :A, :A, :A, :A]


This test is unlikely, but it's not impossible.

CheezItMan · 2018-03-02T00:29:35Z

specs/tile_bag_spec.rb

+      result.must_equal 93
+    end
+
+    it 'returns tiles remaining if less than number of tiles requested' do


Good that you're testing this, I would also assert that result would be equal to 98.

CheezItMan · 2018-03-02T00:32:08Z

specs/player_spec.rb

+
+      # Assert
+      result.must_equal 60
+    end


You should also have a Player test for drawing tiles.

kseastman and others added 30 commits February 20, 2018 14:28

Added a method to score words, verified functional in pry.

2285b0f

Fix plus fifty bug

0fdc56b

just want to get the updated file

df36181

I was following along at home, just want the official file from my pa…

32f0ab4

…rtner Merge branch 'master' of https://github.com/kseastman/Scrabble

8 assertions, 3 failures, no errors

6a10b59

this is garbage I want to rewrite with wenjie's

55427f3

Fix nonletter input

3210778

Merge branch 'master' of https://github.com/kseastman/Scrabble

a5ddfed

Tests are green, may need to refactor.

b9268b2

remove binding.pry

079d74e

Add Scoring.highest_score_from method

f2fb56a

defined method self.tie_winner, and should handle ties for length, no…

9c27828

…t 7 letters or anything like that.

Finish method Scoring.highest_score_from

d13e11f

Add test parts for the method as well. Tested. Working as expected

Merge branch 'master' of https://github.com/kseastman/Scrabble

e0c0ea7

Refactoring

6aefdff

commiting so I can pull Wenjie's changes.

4382409

Merge branch 'master' of https://github.com/kseastman/Scrabble

282ebf0

changed test for tied and 7 letters to include words that tie, test n…

77faf69

…ow fails, refactoring code to pass.

Tests are green for prioritization of ties.

416a711

player spec, partial stubs

5a6964a

Create Player class and the constructor

b5f270b

completely stubbed

47a2c63

Merge branch 'master' of https://github.com/kseastman/Scrabble

e83899e

Merge changes

c845e97

fixed issue

4048b11

Merge changes

63149cd

Merge branch 'master' of https://github.com/kseastman/Scrabble

62848bd

Merge branch 'master' of https://github.com/kseastman/Scrabble

a65a3ae

Add Player#play method

298d89b

things and stuff

30e560e

kseastman and others added 28 commits February 21, 2018 16:04

added test for won?

d6a6256

Merge branch 'master' of https://github.com/kseastman/Scrabble

2fcf18f

Merge branch 'master' of https://github.com/kseastman/Scrabble

0aa3237

Fix a bug

122d5b5

Merge branch 'master' of https://github.com/kseastman/Scrabble

5fa0a56

added test for highest_scoring_word

b3c5ba8

all done, possibly...

81c2fa5

haha, my lie. Now they are done.

168fee9

opening wave 3

38cf854

Create TileBag class and Tile class

f891439

- create constructor in TileBad class - create two methods: create_tiles and draw_tiles - create instance variable tiles_remaining

Fix draw_tile method

fdac8cd

Specs file empty, not stubbed

e29525a

Merge branch 'master' of https://github.com/kseastman/Scrabble

5567bdf

Tests are live, and code is ready to be refactored.

dde8e48

Add instance method tiles

5b3fa1d

Remove tests

4586221

Merge branch 'master' of https://github.com/kseastman/Scrabble

c8fa4a2

added individual test arranges

3396094

added individual test arranges and removed variable result

9c3de0e

"changes made, should be mostly working"

0cb4a8d

player is having issues limiting to tiles, wave-3-game I reset to normal

5c211ce

- Add tests for .play(word) take care of tiles

d6baceb

- Change all tiles to array of symbols

Change Player#play(word) method to check if user won first

f183256

-Change name test to the_test

e37b281

-Add a few in class Player -All tests for class Player passed

Modify one conditional st

aa3957e

Add test for edge case in Player#play method

21d2ab7

This test did not pass, need modify code

Most recent stable version

e61077e

Refactor Player.won method

50d3d7f

CheezItMan reviewed Mar 2, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wenjie & Kat - Octos - Scrabble #5

Wenjie & Kat - Octos - Scrabble #5

kseastman commented Feb 23, 2018

CheezItMan commented Mar 2, 2018

CheezItMan Mar 1, 2018

CheezItMan Mar 1, 2018

CheezItMan Mar 1, 2018

CheezItMan Mar 2, 2018

CheezItMan Mar 2, 2018

CheezItMan Mar 2, 2018

CheezItMan Mar 2, 2018

CheezItMan Mar 2, 2018

Wenjie & Kat - Octos - Scrabble #5

Are you sure you want to change the base?

Wenjie & Kat - Octos - Scrabble #5

Conversation

kseastman commented Feb 23, 2018

Scrabble

Comprehension Questions

CheezItMan commented Mar 2, 2018

Scrabble

What We're Looking For

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment