Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

&&: Monalisa's Hotel #25

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

&&: Monalisa's Hotel #25

wants to merge 18 commits into from

Conversation

MonalisaC
Copy link

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision? As per user stories Class Administrator/front-desk will use the system and tracking reservation is done by it. So all the methods related to that are in that class.
Describe a concept that you gained more clarity on as you worked on this assignment. OOD and coming up minimum design.
Describe a nominal test that you wrote for this assignment. Method list_rooms can access the list of all of the rooms in the hotel.
Describe an edge case test that you wrote for this assignment. Method list_available_rooms returns empty when all rooms are reserved.
How do you feel you did in writing pseudocode first, then writing the tests and then the code? I tried and improved working on this project.

@kariabancroft
Copy link

Hotel

What We're Looking For

Feature Feedback
Design
Demonstrated classes having a single responsibility Yes - nice job using inheritance for your block. I like the way you used custom errors for hotel-specific logic.
Demonstrated loose coupling Yes
Methods demonstrate a good use of encapsulation, inputs and outputs Yes
Wave 1 requirements Yes
Wave 2 requirements Yes
Wave 3 requirements Yes

You did a nice job exercising your Ruby knowledge in method and class creation as well as testing in this assignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants