Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers: Nora Peters #31

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Ampers: Nora Peters #31

wants to merge 28 commits into from

Conversation

npeters5
Copy link

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision? I had to decide how many classes to set up, and what attributes and behaviors each class should have. I decided to have four classes: FrontDesk, Room, Reservation, and Block. And for the sake of SRP, I designed Room to hold on to their own reservations and blocks, instead of centralizing them in FrontDesk, and duplicating them elsewhere.
Describe a concept that you gained more clarity on as you worked on this assignment. I gained some more clarity on composition and optional/keyword arguments, though I still need to work on the latter. Also learned about SimpleCov and Rubocop, and some tricks in Minitest.
Describe a nominal test that you wrote for this assignment. Creating a reservation for 5 days with plenty of available rooms.
Describe an edge case test that you wrote for this assignment. Trying to create a reservation with non-Date objects, or if the end date is before the start date.
How do you feel you did in writing pseudocode first, then writing the tests and then the code? I think I did really well in attempting to plan with a UML diagram, then writing pseudocode, then TDD red, green refactor.

NOTE: I'm submitting in order to meet the deadline, and I think I'm meeting most of the requirements, but will be refactoring some more over the next few days. I struggled A LOT with this project in the beginning so I was really slow to get going; but I'm finally gaining momentum and have a better understanding of how my program works, so I'll be adding some more tests and fine-tuning.

npeters5 added 23 commits March 5, 2018 14:06
…thod. all pass, but need to be broken into diff it blocks. stubbed methods for cost and duration in Reservation class. wrote private helper methods in FrontDesk to validate and convert start and end date input to Date objects.
…ng the input into a Date object is outside the scope of the user stories provided
…simplecov says I have 100% coverage so far and yet I am feeling like an utter failure. how does that make sense?
…n front_desk classand adds ranges to room instances instead of duplicating the entire reservation object inside the room object
… an optional room number argument, and book that room if it is available
… begin on the end_date of another reservation
… can get list of all available rooms for given date
…iles. created #create_block method in FrontDesk and some tests. Created additional helper methods inside Room to create and store new blocks. updated #available_rooms in FrontDesk to not return any blocked rooms.
@kariabancroft
Copy link

Hotel

What We're Looking For

Feature Feedback
Design
Demonstrated classes having a single responsibility Yes - nice job separating out some functionality and using private methods. The code overall is easy to read and methods are named well.
Demonstrated loose coupling Yes
Methods demonstrate a good use of encapsulation, inputs and outputs Yes - most of the time. I'm not sure the methods in Room are using the best possible return values.
Wave 1 requirements Yes
Wave 2 requirements Yes
Wave 3 requirements Incomplete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants