forked from AdaGold/hotel
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ampers: Nora Peters #31
Open
npeters5
wants to merge
28
commits into
Ada-C9:master
Choose a base branch
from
npeters5:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lecov required and started on spec_helper
…ax num rooms. wrote pseudeocode in admin.rb
…d tests currently passing
…thod. all pass, but need to be broken into diff it blocks. stubbed methods for cost and duration in Reservation class. wrote private helper methods in FrontDesk to validate and convert start and end date input to Date objects.
…ng the input into a Date object is outside the scope of the user stories provided
…simplecov says I have 100% coverage so far and yet I am feeling like an utter failure. how does that make sense?
…nce of Reservation class
…n front_desk classand adds ranges to room instances instead of duplicating the entire reservation object inside the room object
… an optional room number argument, and book that room if it is available
… begin on the end_date of another reservation
… can get list of all available rooms for given date
…iles. created #create_block method in FrontDesk and some tests. Created additional helper methods inside Room to create and store new blocks. updated #available_rooms in FrontDesk to not return any blocked rooms.
HotelWhat We're Looking For
|
…olate object instance creation
…future use. completed design-activity.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotel
Congratulations! You're submitting your assignment!
Comprehension Questions
NOTE: I'm submitting in order to meet the deadline, and I think I'm meeting most of the requirements, but will be refactoring some more over the next few days. I struggled A LOT with this project in the beginning so I was really slow to get going; but I'm finally gaining momentum and have a better understanding of how my program works, so I'll be adding some more tests and fine-tuning.