Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jamila Cornick Octos #35

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Jamila Cornick Octos #35

wants to merge 9 commits into from

Conversation

Jcornick21
Copy link

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision? I decided to make a class for rooms and also gave it a status. It seems like I didn tnecessarily need to. I probably would have changed that if I had more time to work on the project.
Describe a concept that you gained more clarity on as you worked on this assignment. Igained more clarity around the idea that my administrator class would have access to everything but not everything would have access to administrator class
Describe a nominal test that you wrote for this assignment. I tested to see ifmy administrator class could access the total cost associated with my reservations.
Describe an edge case test that you wrote for this assignment. Didnt get to writing edge cases I was trying to finish nominal cases and code first
How do you feel you did in writing pseudocode first, then writing the tests and then the code? This process is great! very helpful.

@room_list = all_rooms
@reservation_list = []

if reservation_list == []

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would this code path be executed where this conditional is false?

res_cost = reservation.total_cost
# puts res_cost
return res_cost
elsif reservation.guest != res_name

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen with this if the reservation you're looking for is the second in the list? (hint: unexpected behavior)

(num_of_rooms).times do
reserved_unit = rm_units.sample
if reserved_unit.status == :UNAVAILABLE
while reserved_unit.status == :UNAVAILABLE

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need an if and a while?

@kariabancroft
Copy link

Hotel

What We're Looking For

Feature Feedback
Design
Demonstrated classes having a single responsibility Yes - I like the way you tracked the rooms with their status, this is definitely a challenge!
Demonstrated loose coupling Yes
Methods demonstrate a good use of encapsulation, inputs and outputs Yes
Wave 1 requirements Yes
Wave 2 requirements Yes
Wave 3 requirements No

More commits would be good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants