Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tor S - Octos - Hotel #38

Open
wants to merge 51 commits into
base: master
Choose a base branch
from
Open

Tor S - Octos - Hotel #38

wants to merge 51 commits into from

Conversation

torshimizu
Copy link

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision? I chose to have Room and Block as their own classes. I went between having them as a hash with info (and a required room number) or as a class. I felt like working with a class is much clearer because you can always require certain pieces of information for the object to exist. I also found that I had some actions for the Room class.
Describe a concept that you gained more clarity on as you worked on this assignment. Object composition
Describe a nominal test that you wrote for this assignment. A nominal test I wrote for Admin#new_reservation was that admin could reserve an available room.
Describe an edge case test that you wrote for this assignment. An edge case I wrote for Admin#new_reservation was that it would throw an error if there were no more rooms available for that date.
How do you feel you did in writing pseudocode first, then writing the tests and then the code? This was very helpful for figuring out Room#check_availability! There were many paths to consider when blocks came along for the availability of a room.

…ableRoom, method to add reservation to room's collection of reservations
…k and available if reserving within the block
…reserve a room in a block when not associated with that block
… rooms in a block, added error for reserving a block without a block last name)
… a block and Admin#calculate_reservation_cost tests for block pricing
@kariabancroft
Copy link

Hotel

What We're Looking For

Feature Feedback
Design
Demonstrated classes having a single responsibility Yes. Glad you abstracted out the date logic into the DateHelper. Also, adding custom errors! Neat!
Demonstrated loose coupling Yes
Methods demonstrate a good use of encapsulation, inputs and outputs Yes
Wave 1 requirements Yes
Wave 2 requirements Yes
Wave 3 requirements Yes

Really nice job with git commits! Your code looks great, really nice job overall.

@torshimizu
Copy link
Author

Hey Kari, is there anything I could be working on or updating or improving before we go into the hotel revisited project over the weekend?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants