Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submitting project #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

submitting project #44

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 12, 2018

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?
Describe a concept that you gained more clarity on as you worked on this assignment.
Describe a nominal test that you wrote for this assignment.
Describe an edge case test that you wrote for this assignment.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?

end

def book_room(start_date, end_date)
available_rooms = find_room(start_date, end_date)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is find_room implemented?


def available_rooms(start_date, end_date)
invalid?(start_date, end_date)
available_rooms = @rooms_reservations

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this instance variable set?


end

def room_number

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would this be a method and not an attr_accessor?

end

def start_date
return @start_date.strftime

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic should be done in the initialize and then just use attr_accessors to access the updated data

@kariabancroft
Copy link

Hotel

What We're Looking For

Feature Feedback
Design
Demonstrated classes having a single responsibility Yes, mostly. Though a few of the basics usages of instance variables are misguided.
Demonstrated loose coupling Yes
Methods demonstrate a good use of encapsulation, inputs and outputs Yes
Wave 1 requirements Incomplete
Wave 2 requirements Incomplete
Wave 3 requirements No

You absolutely need to be using git more often. This is non-negotiable. You also must be answering the comprehension questions when you turn in your assignments. It seems that much of this submitted code would not run, as-is, so you need you get this code working and notify your instructor when this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant