Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotel - Emilce - Octos #46

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

emilcecarlisa
Copy link

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision? It was difficult deciding what structure the instances of reservation should take. I based my decision on what I thought would be easier to access, given the requirements.
Describe a concept that you gained more clarity on as you worked on this assignment. I have a better understanding of why we use classes over hashes. For example the reservation class has more complex behavior than what a hash could/should handle.
Describe a nominal test that you wrote for this assignment. I wrote tests for the initialization of the admin and reservation classes.
Describe an edge case test that you wrote for this assignment. Still skimping on the edge cases. I will continue to work on these in the coming days.
How do you feel you did in writing pseudocode first, then writing the tests and then the code? I don't think writing pseudocode helped me that much. I had a much clearer picture once I started coding and tutors/peers were able to explain things to me.

@kariabancroft
Copy link

Hotel

What We're Looking For

Feature Feedback
Design
Demonstrated classes having a single responsibility Yes
Demonstrated loose coupling Yes
Methods demonstrate a good use of encapsulation, inputs and outputs Mostly - what about output on the make_reservation method?
Wave 1 requirements Yes
Wave 2 requirements Yes
Wave 3 requirements No

You github integration in your terminal is broken, so you should check in with someone to fix this, or use this link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants