Ampers: Abinnet

[Abiaina]

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	Forgetting to close a tag and removing a tag without content. This helped fix the hyperlink on text issue I had on my about me page.
Why is it important to consider and use semantic HTML?	It makes it more organized to read and write the code and it allows for equity of access to my web content by working with web readers.
How did you decide to structure your CSS?	I liked circles and simple clean graphics
What was the most challenging piece of this assignment?	Making the nav bar that had homepage icon of mini nav bar images.
Describe one area that you gained more clarity on when completing this assignment	the importance of testing it out as my code is written and how to connect css to html and the multiple pages.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall	I had some trouble with the page in the beginning and still have some parts of the site that I want to make better (like the hover over the home page icon changing the transparency of all the pics not jus the one where the mouse is. Also making the images circles not just circular (there was a lot of ovals that I wanted to be circles).

[CheezItMan]

Personal Portfolio Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	Only 3 commits, but I understand it's harder to remember to commit in an HTML page.
Answered comprehension questions	Check
Page fully loads	Check
No broken links (regular or images)	One broken link going here for your Hotel project I think.
Includes at least 4 pages and styling	Check
HTML
Uses the high-level tags for organization: header, footer, main	Your index.html page only has a nav & footer, that doesn't seem like enough. A lot of your pages like green and watercolors are missing body tags. Not good. When you're turning in an HTML site, put it through a validator.
Appropriately using semantic tags: section, article, etc.	Pretty good use of semantic HTML. Some of the sections could be main elements.
All images include alternate text	Check
CSS
Using class and ID names in style declarations	Check, I would default to normally using classes in styling as it's easier to override and reuse the styling.
Style declarations are DRY	NOPE you're redeclaring a lot of the styles in separate CSS files. I would avoid that whereever possible.
Overall	Small pet peeve, capitalize your name in the footers. It doesn't look so good. I would also suggest finding a layout you like on the internet and trying to imitate it. The current site looks more than a little spare. You need to work on DRYing your CSS and putting your HTML through a validator. I would also in future Rails sites to put some work into designing a layout.

[CheezItMan]

body??? This happens a few times.

[CheezItMan]

Capitalize your name plz.

[CheezItMan]

I've seen this exact CSS rule in a lot of files. Try having one css file and sharing the styles. It will be easier to maintain.