chore Fix all warnings (#1468)

## Summary
- Using `Void?` as associated key type as described
[here](https://github.com/atrick/swift-evolution/blob/diagnose-implicit-raw-bitwise/proposals/nnnn-implicit-raw-bitwise-conversion.md#workarounds-for-common-cases)
- ~Using `PKShippingContactEditingMode.available` instead of `.enabled`
because of deprecation~
  - Actually this is only available/deprecated using Xcode 15 🤷 
- Increasing linting file-line-limit-warning to 500
- Splitting up function/class bodies
- Reducing `swiftlint:disable`

Author: goergisn

.swiftlint.yml

@@ -19,3 +19,6 @@ line_length:
   ignores_function_declarations: true
   ignores_urls: true
   warning: 140
+  
+file_length:
+  warning: 500

Adyen/Core/Components/AbstractPersonalInformationComponent/AbstractPersonalInformationComponent.swift

@@ -235,7 +235,7 @@ open class AbstractPersonalInformationComponent: PaymentComponent, PresentableCo
             lastNameItem?.value = $0.lastName
         }
         shopperInformation.emailAddress.map { emailItem?.value = $0 }
-        shopperInformation.telephoneNumber.map { phoneItem?.value = $0 }
+        shopperInformation.phoneNumber.map { phoneItem?.value = $0.value }
         shopperInformation.billingAddress.map { addressItem?.value = $0 }
         shopperInformation.deliveryAddress.map { deliveryAddressItem?.value = $0 }
     }

Adyen/Core/Core Protocols/Component.swift

@@ -1,5 +1,5 @@
 //
-// Copyright (c) 2022 Adyen N.V.
+// Copyright (c) 2023 Adyen N.V.
 //
 // This file is open source and available under the MIT license. See the LICENSE file for more info.
 //
@@ -65,9 +65,9 @@ public extension Component {
 }
 
 private enum AssociatedKeys {
-    internal static var isDropIn = "isDropInObject"
+    internal static var isDropIn: Void?
 
-    internal static var environment = "environmentObject"
+    internal static var environment: Void?
 
-    internal static var clientKey = "clientKeyObject"
+    internal static var clientKey: Void?
 }

Adyen/Core/Core Protocols/PaymentAwareComponent.swift

@@ -1,5 +1,5 @@
 //
-// Copyright (c) 2022 Adyen N.V.
+// Copyright (c) 2023 Adyen N.V.
 //
 // This file is open source and available under the MIT license. See the LICENSE file for more info.
 //
@@ -37,7 +37,7 @@ extension PartialPaymentOrderAware {
 
 private enum AssociatedKeys {
 
-    internal static var payment = "paymentObject"
+    internal static var payment: Void?
 
-    internal static var order = "orderObject"
+    internal static var order: Void?
 }

Adyen/Core/Models/CardType.swift

@@ -83,7 +83,7 @@ public enum CardType: RawRepresentable, Codable, Equatable, Hashable {
 
     /// Korea Cyber Payment
     case kcp
-
+    
     /// Korean local card
     case koreanLocalCard
 
@@ -141,7 +141,7 @@ public enum CardType: RawRepresentable, Codable, Equatable, Hashable {
     /// Fallback option for any other scheme name
     case other(named: String)
 
-    // swiftlint:disable cyclomatic_complexity
+    // swiftlint:disable cyclomatic_complexity function_body_length
     public init(rawValue: String) {
         switch rawValue {
         case "accel": self = .accel
@@ -292,7 +292,7 @@ public enum CardType: RawRepresentable, Codable, Equatable, Hashable {
         case let .other(name): return name.replacingOccurrences(of: "_", with: " ")
         }
     }
-    // swiftlint:enable cyclomatic_complexity
+    // swiftlint:enable cyclomatic_complexity function_body_length
 }
 
 extension CardType {

Adyen/Core/Payment Methods/Abstract/PaymentMethodType.swift

@@ -63,7 +63,7 @@ public enum PaymentMethodType: RawRepresentable, Hashable, Codable {
     case other(String)
 
     // swiftlint:disable cyclomatic_complexity function_body_length
-
+    
     public init?(rawValue: String) {
         switch rawValue {
         case "card": self = .card
@@ -122,7 +122,7 @@ public enum PaymentMethodType: RawRepresentable, Hashable, Codable {
         default: self = .other(rawValue)
         }
     }
-
+    
     public var rawValue: String {
         switch self {
         case .card: return "card"
@@ -180,6 +180,9 @@ public enum PaymentMethodType: RawRepresentable, Hashable, Codable {
         case let .other(value): return value
         }
     }
+}
+
+extension PaymentMethodType {
 
     /// The brand name of the card type
     ///

Adyen/Helpers/UIViewAnimation.swift

@@ -7,7 +7,7 @@
 import UIKit
 
 private enum AssociatedKeys {
-    internal static var animations = "animations"
+    internal static var animations: Void?
 }
 
 @_spi(AdyenInternal)

Adyen/UI/Form/Items/Phone Number/FormPhoneNumberItem.swift

@@ -1,5 +1,5 @@
 //
-// Copyright (c) 2022 Adyen N.V.
+// Copyright (c) 2023 Adyen N.V.
 //
 // This file is open source and available under the MIT license. See the LICENSE file for more info.
 //
@@ -31,11 +31,15 @@ public final class FormPhoneNumberItem: FormTextItem {
                 selectableValues: [PhoneExtensionPickerItem],
                 style: FormTextItemStyle,
                 localizationParameters: LocalizationParameters? = nil) {
-        // swiftlint:disable:next line_length
-        let preselectedValue = selectableValues.first(where: { $0.element.value == phoneNumber?.callingCode }) ?? selectableValues.first(where: { $0.identifier == Locale.current.regionCode }) ?? selectableValues[0]
-
-        phonePrefixItem = FormPhoneExtensionPickerItem(preselectedValue: preselectedValue, selectableValues: selectableValues, style: style)
+        
+        phonePrefixItem = FormPhoneExtensionPickerItem(
+            preselectedValue: selectableValues.preselectedPhoneNumberPrefix(for: phoneNumber),
+            selectableValues: selectableValues,
+            style: style
+        )
+        
         super.init(style: style)
+        
         phonePrefixItem.identifier = ViewIdentifierBuilder.build(scopeInstance: self, postfix: "phoneExtensionPickerItem")
         value = phoneNumber?.value ?? ""
 
@@ -50,5 +54,25 @@ public final class FormPhoneNumberItem: FormTextItem {
     override public func build(with builder: FormItemViewBuilder) -> AnyFormItemView {
         builder.build(with: self)
     }
+}
+
+private extension [PhoneExtensionPickerItem] {
 
+    func preselectedPhoneNumberPrefix(for phoneNumber: PhoneNumber?) -> PhoneExtensionPickerItem {
+        
+        if let matchingCallingCode = first(where: { $0.element.value == phoneNumber?.callingCode }) {
+            return matchingCallingCode
+        }
+        
+        if let matchingLocaleRegion = first(where: { $0.identifier == Locale.current.regionCode }) {
+            return matchingLocaleRegion
+        }
+        
+        if let firstSelectableValue = first {
+            return firstSelectableValue
+        }
+        
+        AdyenAssertion.assertionFailure(message: "Empty list of selectableValues provided")
+        return .init(identifier: "", element: .init(value: "+1", countryCode: "US"))
+    }
 }

Adyen/UI/List/ListItem.swift

@@ -94,7 +94,7 @@ public class ListItem: FormItem {
 
     private func setLoading(_ isLoading: Bool) {
         guard let loadingHandler else {
-            assertionFailure("No loadingHandler provided")
+            AdyenAssertion.assertionFailure(message: "No loadingHandler provided")
             return
         }
 

Adyen/UI/View Controllers/AddressLookup/AddressLookupViewController.swift

@@ -79,9 +79,9 @@ private extension AddressLookupViewController {
     }
 }
 
-internal extension AddressLookupViewController.ViewModel {
+extension AddressLookupViewController.ViewModel {
 
-    func buildAddressInputFormViewModel(
+    internal func buildAddressInputFormViewModel(
         with prefillAddress: PostalAddress?
     ) -> AddressInputFormViewController.ViewModel {
 
@@ -96,7 +96,7 @@ internal extension AddressLookupViewController.ViewModel {
         )
     }
 
-    func buildAddressSearchViewModel(
+    internal func buildAddressSearchViewModel(
         presentationHandler: @escaping (UIViewController) -> Void
     ) -> AddressLookupSearchViewController.ViewModel {