Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore Upgrade test pipeline #1462

Merged
merged 86 commits into from
Jan 5, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
86 commits
Select commit Hold shift + click to select a range
5fbc5cb
Switching to Sonoma and Xcode 15 + iOS 17
goergisn Nov 16, 2023
61d518a
Moving 16.4 to our compatibility tests
goergisn Nov 16, 2023
01f4d4c
Update build.yml
goergisn Nov 16, 2023
d89ba29
Merge branch 'develop' into use-xcode-15
goergisn Nov 16, 2023
e40db28
Using macos-13-xl
goergisn Nov 16, 2023
ff3f7fb
Update pr_scan.yml
goergisn Nov 16, 2023
6a4c08e
Experimenting with snapshot updating
goergisn Nov 17, 2023
bf2efc2
Update pr_scan.yml
goergisn Nov 17, 2023
27d6843
Update pr_scan.yml
goergisn Nov 17, 2023
48716f4
Tmp disabling integration tests
goergisn Nov 17, 2023
5899888
Some more testing
goergisn Nov 17, 2023
27dfa1d
More troubleshooting
goergisn Nov 17, 2023
186f6ce
Update pr_scan.yml
goergisn Nov 17, 2023
70dabc7
Update pr_scan.yml
goergisn Nov 17, 2023
68db95c
Update pr_scan.yml
goergisn Nov 17, 2023
c15197c
Update pr_scan.yml
goergisn Nov 17, 2023
3e7ade8
Updating snapshots
goergisn Nov 20, 2023
0b97b78
Reverted snapshot updating
goergisn Nov 20, 2023
85b72ff
Fixing some tests for iOS 17
goergisn Nov 20, 2023
9155d04
Longer timeout
goergisn Nov 20, 2023
d1cfe3f
Update AffirmComponentUITests.swift
goergisn Nov 20, 2023
e7a3c2e
Updated snapshots
goergisn Nov 20, 2023
1111c22
Better snapshots
goergisn Nov 20, 2023
9e8ea64
Re-enabling workflows
goergisn Nov 20, 2023
b0cf5cf
Small tweaks
goergisn Nov 21, 2023
7ea129a
Troubleshooting
goergisn Nov 21, 2023
b3e0d74
More Troubleshooting
goergisn Nov 21, 2023
e33e30e
Update pr_scan.yml
goergisn Nov 21, 2023
51c9c8a
Snapshot updates
goergisn Nov 21, 2023
81ee39d
Increasing waiting times
goergisn Nov 21, 2023
a3ef3df
Even longer timeouts
goergisn Nov 21, 2023
4f0797b
Hardening card component tests
goergisn Nov 21, 2023
8031a8f
Better waiting
goergisn Nov 21, 2023
ee6b0e5
Some small adjustments
goergisn Nov 22, 2023
99f3185
Actually waiting for expectations
goergisn Nov 22, 2023
9353611
Merge branch 'develop' into use-xcode-15
goergisn Nov 22, 2023
3022c8d
Update ThreeDS2PlusDACoreActionHandlerTests.swift
goergisn Nov 22, 2023
1f324c3
Fixing compatibility test
goergisn Nov 22, 2023
09e1b9e
Waiting for animations to be finished
goergisn Nov 23, 2023
426a940
Is this really better?
goergisn Nov 23, 2023
1dd77ca
Fixing tests
goergisn Nov 23, 2023
eee9319
Update CardComponentTests.swift
goergisn Nov 23, 2023
43348c4
Update BLIKComponentUITests.swift
goergisn Nov 23, 2023
3f05b17
Merge branch 'develop' into use-xcode-15
goergisn Nov 23, 2023
4beb178
Merge conflicts
goergisn Nov 23, 2023
5921daa
Updated snapshots
goergisn Nov 23, 2023
de3e5ba
Update Configuration.swift
goergisn Nov 23, 2023
46b9b99
Update DropInTests.swift
goergisn Nov 24, 2023
2e82b74
Revert "Update DropInTests.swift"
goergisn Nov 24, 2023
d68e21e
Let's wait a little longer
goergisn Nov 27, 2023
e9f022f
Merge branch 'develop' into use-xcode-15
goergisn Nov 27, 2023
b29c98e
Verify snapshot with timeout
goergisn Nov 28, 2023
a25556e
Merge branch 'develop' into use-xcode-15
goergisn Nov 28, 2023
3582a90
Fixing bug in waiting method
goergisn Nov 29, 2023
15e238a
Increasing the pause between snapshot comparisons
goergisn Nov 29, 2023
5779aef
Merge branch 'develop' into use-xcode-15
goergisn Nov 29, 2023
6d2c170
Resolving conflicts
goergisn Dec 4, 2023
fbadedd
Revert
goergisn Dec 4, 2023
c89297e
Harden test
goergisn Dec 7, 2023
0f0f948
Merge branch 'develop' into use-xcode-15
goergisn Dec 7, 2023
0eee2d6
longer timeouts
goergisn Dec 8, 2023
43e9b99
Update ACHDirectDebitComponentTests.swift
goergisn Dec 8, 2023
a849711
Better waiting
goergisn Dec 8, 2023
3b8fbe9
Wait for end editing
goergisn Dec 8, 2023
2acb8b6
More smart waiting
goergisn Dec 11, 2023
819f4be
Increasing timeouts
goergisn Dec 11, 2023
785177f
Merge branch 'develop' into use-xcode-15
goergisn Dec 11, 2023
256805e
Re-enabling isValid checks
goergisn Dec 11, 2023
e121d30
Some refactoring
goergisn Dec 14, 2023
761ca98
Merge branch 'develop' into use-xcode-15
goergisn Dec 19, 2023
cc4ad6a
Longer waiting
goergisn Dec 20, 2023
9495aa2
Switching UI and UnitTest order
goergisn Dec 20, 2023
e99b140
pre heating simulator + disabling other workflows for now
goergisn Dec 21, 2023
5a56723
Update pr_scan.yml
goergisn Dec 21, 2023
c6c2ce4
Update pr_scan.yml
goergisn Dec 21, 2023
8a2b105
Update pr_scan.yml
goergisn Dec 21, 2023
0c50be1
Another try
goergisn Dec 21, 2023
870ada8
Update pr_scan.yml
goergisn Dec 21, 2023
871be8f
Maybe now?
goergisn Dec 21, 2023
58fa559
switching back to intel?
goergisn Dec 21, 2023
b09415b
reverting changes
goergisn Dec 22, 2023
22dc781
Trying Xcode 15.1 + iOS 17.2
goergisn Dec 22, 2023
e54fbe1
Updated snapshots
goergisn Dec 22, 2023
841ebe3
Merge branch 'develop' into use-xcode-15
goergisn Dec 22, 2023
90ba721
Update pr_scan.yml
goergisn Jan 3, 2024
e294d57
Update pr_scan.yml
goergisn Jan 3, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,30 +8,38 @@ on:

jobs:
tests:
runs-on: macos-12
runs-on: ${{ matrix.os }}
continue-on-error: false
strategy:
fail-fast: false
matrix:
include:

- version: '16.4'
displayname: 'iPhone 14'
os: 'macos-13-xl'
needs_custom_sim: false # Takes the shipped simulator that comes with Xcode 13

- version: '15.0'
device: 'iPhone 13'
runtime: 'iOS-15-0'
device: 'iPhone 13'
displayname: 'iPhone-13'
scheme: 'AdyenUIKitTests' # Only UnitTests as UI could differ between iOS versions
os: 'macos-12-xl'
needs_custom_sim: true

- version: '14.2'
device: 'iPhone 12'
displayname: 'iPhone-12'
runtime: 'iOS-14-2'
scheme: 'AdyenUIKitTests' # Only UnitTests as UI could differ between iOS versions
os: 'macos-12-xl'
needs_custom_sim: true

- version: '13.7'
device: 'iPhone 11'
runtime: 'iOS-13-7'
device: 'iPhone 11'
displayname: 'iPhone-11'
scheme: 'AdyenUIKitTests' # Only UnitTests as UI could differ between iOS versions
os: 'macos-12-xl'
needs_custom_sim: true

steps:
- uses: actions/checkout@v4
Expand All @@ -43,7 +51,8 @@ jobs:
run: |
sudo mkdir -p /Library/Developer/CoreSimulator/Profiles/Runtimes

- name: Prepare ${{ matrix.destination }}
- name: Prepare ${{ matrix.version }}
if: matrix.needs_custom_sim
run: |
xcversion simulators --install="iOS ${version}"
xcrun simctl list devices ${version}
Expand All @@ -56,9 +65,10 @@ jobs:

- name: Build and test
run: |
xcodebuild build test -project ${project} -scheme "${scheme}" ${params} -destination ${destination} | xcpretty --utf --color && exit ${PIPESTATUS[0]}
xcodebuild build test -project ${project} -scheme "${scheme}" ${params} -destination "${destination}" | xcpretty --utf --color && exit ${PIPESTATUS[0]}
env:
project: 'Adyen.xcodeproj'
params: "-skipPackagePluginValidation"
scheme: ${{ matrix.scheme }}
scheme: 'AdyenUIKitTests'
destination: "OS=${{ matrix.version }},name=${{ matrix.displayname }}"

4 changes: 2 additions & 2 deletions .github/workflows/pr_scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Select latest Xcode
uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: '14.3'
xcode-version: '15.0.1'

- name: Install Tools
run: |
Expand All @@ -46,7 +46,7 @@ jobs:
project: 'Adyen.xcodeproj'
params: '-derivedDataPath ./DerivedData -enableCodeCoverage YES -skipPackagePluginValidation'
scheme: 'AdyenUIHost'
destination: 'name=iPhone 14,OS=16.4'
destination: 'name=iPhone 14,OS=17.0'

- name: Code Coverage
run: |
Expand Down