Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix Submit action is still disabled after CVC is filled #1499

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

goergisn
Copy link
Contributor

@goergisn goergisn commented Dec 22, 2023

Summary

  • Aligning stored card CVC validation with FormCardSecurityCodeItem
  • Fixes a bug where the CVC validation prevented activation of the pay button in the stored card component when using the Traditional Chinese Cantonese keyboard

Fixes


Fixes: #1498
Might also fix: #1188

@goergisn goergisn added the bug label Dec 22, 2023
@goergisn goergisn requested a review from erenbesel December 22, 2023 11:00
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']

@goergisn goergisn requested a review from descorp December 22, 2023 11:57
Copy link

@goergisn goergisn added fixed a pull request that fixes a bug and removed bug labels Dec 22, 2023
@goergisn goergisn merged commit 4ecb2d8 into develop Dec 22, 2023
16 checks passed
@goergisn goergisn deleted the fix-stored-cvc-input branch December 22, 2023 13:38
goergisn added a commit that referenced this pull request Jan 30, 2024
)

## Summary
- Aligning stored card CVC validation with FormCardSecurityCodeItem
- Fixes a bug where the CVC validation prevented activation of the pay
button in the stored card component when using the [Traditional Chiniese
Caontonese keyboard](https://developer.apple.com/forums/thread/741038)
- Same changes as for [v5](#1499)

## Fixes
<fixed>

- For stored card payments using Drop-in, the pay button is now enabled
correctly when entering the security code with the [Traditional Chinese
Cantonese keyboard](https://developer.apple.com/forums/thread/741038)

</fixed>

--------

Fixes: #1498
Might also fix: #1188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed a pull request that fixes a bug
Projects
None yet
3 participants