Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore Improve tintColor tests #1507

Merged
merged 9 commits into from
Jan 18, 2024
Merged

chore Improve tintColor tests #1507

merged 9 commits into from
Jan 18, 2024

Conversation

goergisn
Copy link
Contributor

@goergisn goergisn commented Jan 17, 2024 •
edited
Loading

Summary

  • Using non-dynamic colors to improve reliability of tint color tests
  • Refactoring some tests
  • Skipping testTintColorCustomization for compatibility tests - will be done via snapshotting

@goergisn goergisn changed the title choreUsing non-dynamic colors chore Using non-dynamic colors Jan 17, 2024
github-actions[bot]
github-actions bot requested changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']

@goergisn goergisn changed the title chore Using non-dynamic colors chore Improve tintColor tests Jan 17, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@goergisn goergisn marked this pull request as ready for review January 18, 2024 09:47
@goergisn goergisn added the chore a pull request that has chore changes that shouldn't be in the release notes label Jan 18, 2024
@goergisn goergisn merged commit d624902 into develop Jan 18, 2024
13 checks passed
@goergisn goergisn deleted the fix_tint_color_tests branch January 18, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmamont atmamont atmamont approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@descorp descorp Awaiting requested review from descorp

@erenbesel erenbesel Awaiting requested review from erenbesel

Assignees
No one assigned
Labels
chore a pull request that has chore changes that shouldn't be in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goergisn @atmamont