Card scanner module - Business layer #2008
Conversation
atmamont
added
chore
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nauaros
added
chore
|
✅ No changes detectedComparing Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay |
| private func configureCaptureSession() throws { | ||
| captureSession.beginConfiguration() | ||
|
|
||
| // Set up input |
There was a problem hiding this comment.
These comments are redundant, code speaks better
| } | ||
|
|
||
| private func configureCaptureDevice(_ device: AVCaptureDevice) { | ||
| try? device.lockForConfiguration() |
There was a problem hiding this comment.
What happens if this fails?
| @@ -46,17 +46,17 @@ class CardScannerViewController: UIViewController { | |||
| addOverlayView() | |||
| observeRoiLayoutChanges() | |||
|
|
|||
| viewModel.configureSession() | |||
| viewModel.viewDidLoad() | |||
There was a problem hiding this comment.
These are lifecycle methods of a UIViewController, what is the reason to leak them to the view model layer? This approach might be fragile if we ever decide using this outside of UIKit (think of SwiftUI for example).
| try? device.lockForConfiguration() | ||
|
|
||
| // Adjust Frame Rate | ||
| device.activeVideoMinFrameDuration = CMTime(value: 1, timescale: 15) // 15 fps |
There was a problem hiding this comment.
Should it move to Constants?
| case .portrait: | ||
| return .portrait | ||
| case .landscapeRight: | ||
| return .landscapeLeft // Camera flips the orientation |
There was a problem hiding this comment.
Why do we flip it for both left and right?
Summary
This PR introduces the core UI and business logic for the card scanner, following the MVVM architectural pattern.
CardScannerViewModelAVCaptureSession:AVCaptureDevice:cropRegionOfInterest.CardScannerViewControllerCardScannerOverlayView, which renders the mask and highlights the region of interest.Next Steps
CardImageParser.Ticket
COIOS-826