Skip to content

Remove implicit nullable types #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nek-
Copy link

@Nek- Nek- commented Mar 10, 2025

Description

This should remove a lot of deprecation notice while running the library with php 8.4.

I used rector with the following configurations:

<?php
// rector.php
return Rector\Config\RectorConfig::configure()
    ->withPaths([__DIR__ . '/src'])
    ->withPhpVersion(Rector\ValueObject\PhpVersion::PHP_84)
    ->withRules([
         Rector\Php84\Rector\Param\ExplicitNullableParamTypeRector::class,
    ]);

Since the code is generated I suggest you to add this in your CI/CD flow. Once the config file is added to the project, just run cpx rector/rector.

@Nek- Nek- requested a review from a team as a code owner March 10, 2025 15:52
@aherrao
Copy link

aherrao commented Apr 29, 2025

@Nek- Thank you so much for raising this issue.
Can you please do the needful? We are also looking for these changes in our project update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants