Improve PHP CI workflow #753
Merged
+78
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gcatanese
force-pushed
the
improve-github-workflows
branch
from
20852f0 to
c361cc1
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+16
to
+54
| name: PHP Test | ||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| php-version: [ 7.3, 8.2 ] | ||
| php-version: [ '7.3', '8.2', '8.4' ] | ||
| include: | ||
| - php-version: '8.2' | ||
| validate: true | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Setup PHP | ||
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: ${{ matrix.php-version }} | ||
| tools: composer:v2 | ||
|
|
||
| - name: Validate composer.json and composer.lock | ||
| if: matrix.validate | ||
| run: composer validate --strict | ||
|
|
||
| - name: Check PHP syntax | ||
| if: matrix.validate | ||
| run: find -L . -path ./vendor -prune -o -path ./tests -prune -o -name '*.php' -print0 | xargs -0 -n 1 -P 4 php -l | ||
|
|
||
| - name: Install dependencies | ||
| run: composer install --prefer-dist --no-progress | ||
|
|
||
| - name: Run unit tests | ||
| run: vendor/bin/phpunit --testsuite=unit --coverage-clover build/clover.xml --log-junit build/tests-log.xml | ||
|
|
||
| - name: Clean up reports | ||
| run: sed -i "s;`pwd`/;;g" build/*.xml | ||
|
|
||
| php-lint: |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Comment on lines
+55
to
+76
| name: PHP Lint | ||
| needs: php-test | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| # Disabling shallow clone to improve relevancy of SonarCloud reporting | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Validate composer.json and composer.lock | ||
| run: composer validate --strict | ||
| - name: Setup PHP | ||
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: '8.2' | ||
| tools: composer:v2 | ||
|
|
||
| - name: Install dependencies | ||
| run: composer install --prefer-dist --no-progress | ||
|
|
||
| - name: Run PHP Code Sniffer | ||
| run: vendor/bin/phpcs --exclude=Generic.Files.LineLength | ||
|
|
||
| integration-tests: |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
|
gcatanese
approved these changes
May 6, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Improved the workflow to three main jobs:
php-test: Runs unit tests across multiple php versionsphp-lint: Runs after unit testsintegration-tests: Runs integration tests only for release PRs from the main repositoryRemoved environment variables from unit tests since they should be self-contained
Kept environment variables only in the integration test job where they are needed
Removed CodeQL workflow as PHP language is not yet supported.
Benefits
Testing