Add backward compatibility for translation keys #789
+114
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of ChangesHello @german664, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces backward compatibility for translation keys by loading a swapConfig from CDN with a local fallback. It also includes tests to ensure the backward compatibility works as expected. The review focuses on potential issues related to error handling, and code clarity.
glad-adyen
force-pushed
the
chore/translation-keys
branch
2 times, most recently
from
16f56e0 to
6920a83
Compare
# Conflicts: # src/assets/translations/en-US.instructions.json # src/assets/translations/en-US.json # src/components/external/CapitalOffer/components/CapitalOffer/CapitalOffer.tsx # src/components/external/CapitalOverview/components/CapitalOverview/CapitalOverview.tsx # src/components/external/CapitalOverview/components/GrantItem/GrantItem.tsx # src/components/external/CapitalOverview/components/GrantList/GrantsDisplay.tsx # src/config/translations/swapConfig.json
glad-adyen
force-pushed
the
feature/backtrack-custom-keys
branch
from
d69dabd to
c61acb0
Compare
glad-adyen
force-pushed
the
chore/translation-keys
branch
2 times, most recently
from
08a381d to
f0bdff7
Compare
glad-adyen
reviewed
Oct 16, 2025
glad-adyen
reviewed
Oct 16, 2025
glad-adyen
reviewed
Oct 16, 2025
glad-adyen
reviewed
Oct 16, 2025
glad-adyen
reviewed
Oct 16, 2025
glad-adyen
approved these changes
Oct 17, 2025
|
Size Change: +11.7 kB (+3.67%) Total Size: 330 kB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implementation provides backward compatibility for translation keys that have been renamed, allowing users to continue using old keys in their custom translations without breaking their applications.
When
get(key)is called:swapConfigand the old key is different.Note: array mappings are currently skipped. This is preserved in the swap config for internal use, but will be treated as a new key.