improved select auto expanding, disabled state, and aria-expanded #3698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 30177ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for adyen-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
size-limit report 📦
|
m1aw
force-pushed
the
fix/select-a11y-behaviour
branch
from
ce89ac2 to
ece9725
Compare
m1aw
force-pushed
the
fix/select-a11y-behaviour
branch
from
5e75dff to
9f8946b
Compare
ScottiBR
approved these changes
Dec 15, 2025
Contributor
ScottiBR
left a comment
ScottiBR
left a comment
There was a problem hiding this comment.
Nice, I've also tested the click to pay card list, working as expected announcing the label
ScottiBR
requested changes
Dec 15, 2025
Contributor
ScottiBR
left a comment
ScottiBR
left a comment
There was a problem hiding this comment.
Some unit tests are failing
m1aw
force-pushed
the
fix/select-a11y-behaviour
branch
2 times, most recently
from
54beb09 to
f665d58
Compare
ScottiBR
previously approved these changes
Dec 19, 2025
m1aw
force-pushed
the
fix/select-a11y-behaviour
branch
from
f665d58 to
e9cb7d2
Compare
ScottiBR
force-pushed
the
fix/select-a11y-behaviour
branch
from
24b3be0 to
30177ab
Compare
|
ScottiBR
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Pull Request Checklist
📝 Summary
This PR implements several accessibility improvements for the Select component to enhance screen reader support and keyboard navigation:
Key Changes:
aria-disabled="true"for readonly mode on both button and input elements (CW-25/CW-26)aria-expandedattribute on Select Button for non-filterable selects (CW-27)nullinstead of empty string for better screen reader compatibilityTechnical Improvements:
role="status"andaria-live="polite"🧪 Tested scenarios
aria-disabledattributes are properly set🔗 Related GitHub Issue / Internal Ticket number
Addresses: COSDK-744, CW-24, CW-25, CW-26, CW-27, CW-28, CW-37