Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactor the column type interface #110

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Dec 6, 2024

I think the column type desired a dedicated type instead of an expression.

@git-hulk git-hulk requested a review from Lance726 December 6, 2024 09:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12196740972

Details

  • 62 of 83 (74.7%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 60.243%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/ast.go 27 48 56.25%
Files with Coverage Reduction New Missed Lines %
parser/ast.go 4 56.3%
Totals Coverage Status
Change from base Build 12081993364: -0.09%
Covered Lines: 6334
Relevant Lines: 10514

💛 - Coveralls

@git-hulk git-hulk merged commit 79044fb into AfterShip:master Dec 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants