Skip to content

Add support of accessing the tuple with index field #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions parser/ast.go
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,40 @@ func (p *BinaryOperation) Accept(visitor ASTVisitor) error {
return visitor.VisitBinaryExpr(p)
}

type IndexOperation struct {
LeftExpr Expr
Operation TokenKind
Index Expr
}

func (i *IndexOperation) Accept(visitor ASTVisitor) error {
visitor.enter(i)
defer visitor.leave(i)
if err := i.LeftExpr.Accept(visitor); err != nil {
return err
}
if err := i.Index.Accept(visitor); err != nil {
return err
}
return visitor.VisitIndexOperation(i)
}

func (i *IndexOperation) Pos() Pos {
return i.LeftExpr.Pos()
}

func (i *IndexOperation) End() Pos {
return i.Index.End()
}

func (i *IndexOperation) String() string {
var builder strings.Builder
builder.WriteString(i.LeftExpr.String())
builder.WriteString(string(i.Operation))
builder.WriteString(i.Index.String())
return builder.String()
}

type JoinTableExpr struct {
Table *TableExpr
StatementEnd Pos
Expand Down
8 changes: 8 additions & 0 deletions parser/ast_visitor.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ type ASTVisitor interface {
VisitOperationExpr(expr *OperationExpr) error
VisitTernaryExpr(expr *TernaryOperation) error
VisitBinaryExpr(expr *BinaryOperation) error
VisitIndexOperation(expr *IndexOperation) error
VisitAlterTable(expr *AlterTable) error
VisitAlterTableAttachPartition(expr *AlterTableAttachPartition) error
VisitAlterTableDetachPartition(expr *AlterTableDetachPartition) error
Expand Down Expand Up @@ -188,6 +189,13 @@ func (v *DefaultASTVisitor) VisitBinaryExpr(expr *BinaryOperation) error {
return nil
}

func (v *DefaultASTVisitor) VisitIndexOperation(expr *IndexOperation) error {
if v.Visit != nil {
return v.Visit(expr)
}
return nil
}

func (v *DefaultASTVisitor) VisitJoinTableExpr(expr *JoinTableExpr) error {
if v.Visit != nil {
return v.Visit(expr)
Expand Down
20 changes: 8 additions & 12 deletions parser/lexer.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const (
TokenInt TokenKind = "<int>"
TokenFloat TokenKind = "<float>"
TokenString TokenKind = "<string>"
TokenDot = "."
)

const (
Expand Down Expand Up @@ -328,19 +329,14 @@ func (l *Lexer) consumeToken() error {
return nil
}
case '.':
// check if the next token is a number. If so, parse it as a float number
if l.peekOk(1) && IsDigit(l.peekN(1)) {
return l.consumeNumber()
}
// check if the previous lastToken is an Ident. If so, it's a field name.
if l.lastToken != nil && l.lastToken.Kind != TokenIdent {
return fmt.Errorf("'.' should be after an Ident, but got <%q>", l.lastToken.Kind)
l.lastToken = &Token{
String: l.slice(0, 1),
Kind: TokenDot,
Pos: Pos(l.current),
End: Pos(l.current + 1),
}
}

// The subsequent lastToken after the dot should be an Ident.
if l.lastToken != nil && l.lastToken.Kind == "." && !IsIdentStart(l.peekN(0)) {
return fmt.Errorf("'.' should follow with an Ident, but got <%q>", l.lastToken.Kind)
l.skipN(1)
return nil
}

if IsIdentStart(l.peekN(0)) {
Expand Down
2 changes: 0 additions & 2 deletions parser/lexer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ func TestConsumeNumber(t *testing.T) {
t.Run("Float number", func(t *testing.T) {
floats := []string{
"123.456",
".456",
"123.456e+10",
"123.456e-10",
"123.456e10",
Expand All @@ -126,7 +125,6 @@ func TestConsumeNumber(t *testing.T) {

t.Run("Invalid float number", func(t *testing.T) {
invalidFloats := []string{
".456a",
"123.456b",
"123.456e",
"123.456e+",
Expand Down
2 changes: 1 addition & 1 deletion parser/parse_system.go
Original file line number Diff line number Diff line change
Expand Up @@ -921,7 +921,7 @@ func (p *Parser) parseGrantSource(_ Pos) (*TableIdentifier, error) {
return nil, err
}

if p.tryConsumeTokenKind(".") == nil {
if p.tryConsumeTokenKind(TokenDot) == nil {
return &TableIdentifier{
Table: ident,
}, nil
Expand Down
58 changes: 56 additions & 2 deletions parser/parser_column.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ const (
PrecedenceMulDivMod
PrecedenceBracket
PrecedenceArrow
PrecedenceDot
PrecedenceDoubleColon
)

Expand Down Expand Up @@ -56,6 +57,8 @@ func (p *Parser) getNextPrecedence() int {
return PrecedenceBracket
case p.matchTokenKind(opTypeCast):
return PrecedenceDoubleColon
case p.matchTokenKind(TokenDot):
return PrecedenceDot
case p.matchKeyword(KeywordBetween), p.matchKeyword(KeywordLike), p.matchKeyword(KeywordIlike):
return PrecedenceBetweenLike
case p.matchKeyword(KeywordIn):
Expand All @@ -78,7 +81,7 @@ func (p *Parser) parseInfix(expr Expr, precedence int) (Expr, error) {
p.matchTokenKind(opTypeDiv), p.matchTokenKind(opTypeMod),
p.matchKeyword(KeywordIn), p.matchKeyword(KeywordLike),
p.matchKeyword(KeywordIlike), p.matchKeyword(KeywordAnd), p.matchKeyword(KeywordOr),
p.matchTokenKind(opTypeCast), p.matchTokenKind(opTypeArrow), p.matchTokenKind(opTypeDoubleEQ):
p.matchTokenKind(opTypeArrow), p.matchTokenKind(opTypeDoubleEQ):
op := p.last().ToString()
_ = p.lexer.consumeToken()
rightExpr, err := p.parseSubExpr(p.Pos(), precedence)
Expand All @@ -90,6 +93,38 @@ func (p *Parser) parseInfix(expr Expr, precedence int) (Expr, error) {
Operation: TokenKind(op),
RightExpr: rightExpr,
}, nil
case p.matchTokenKind(opTypeCast):
_ = p.lexer.consumeToken()

if p.matchTokenKind(TokenIdent) && p.last().String == "Tuple" {
name, err := p.parseIdent()
if err != nil {
return nil, err
}
if _, err = p.consumeTokenKind("("); err != nil {
return nil, err
}
// it's a tuple type definition after "::" operator
rightExpr, err := p.parseNestedType(name, p.Pos())
if err != nil {
return nil, err
}
return &BinaryOperation{
LeftExpr: expr,
Operation: opTypeCast,
RightExpr: rightExpr,
}, nil
}

rightExpr, err := p.parseSubExpr(p.Pos(), precedence)
if err != nil {
return nil, err
}
return &BinaryOperation{
LeftExpr: expr,
Operation: opTypeCast,
RightExpr: rightExpr,
}, nil
case p.matchKeyword(KeywordBetween):
return p.parseBetweenClause(expr)
case p.matchKeyword(KeywordGlobal):
Expand All @@ -106,7 +141,24 @@ func (p *Parser) parseInfix(expr Expr, precedence int) (Expr, error) {
Operation: "GLOBAL IN",
RightExpr: rightExpr,
}, nil

case p.matchTokenKind(TokenDot):
_ = p.lexer.consumeToken()
// access column with dot notation
var rightExpr Expr
var err error
if p.matchTokenKind(TokenIdent) {
rightExpr, err = p.parseIdent()
} else {
rightExpr, err = p.parseDecimal(p.Pos())
}
if err != nil {
return nil, err
}
return &IndexOperation{
LeftExpr: expr,
Operation: TokenDot,
Index: rightExpr,
}, nil
case p.matchKeyword(KeywordNot):
_ = p.lexer.consumeToken()
switch {
Expand Down Expand Up @@ -331,6 +383,8 @@ func (p *Parser) parseColumnExpr(pos Pos) (Expr, error) { //nolint:funlen
return p.parseQueryParam(p.Pos())
}
return p.parseMapLiteral(p.Pos())
case p.matchTokenKind(TokenDot):
return p.parseNumber(p.Pos())
case p.matchTokenKind(opTypeQuery):
// Placeholder `?`
_ = p.lexer.consumeToken()
Expand Down
13 changes: 12 additions & 1 deletion parser/parser_common.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ func (p *Parser) parseIdentOrStar() (*Ident, error) {
}

func (p *Parser) tryParseDotIdent(_ Pos) (*Ident, error) {
if p.tryConsumeTokenKind(".") == nil {
if p.tryConsumeTokenKind(TokenDot) == nil {
return nil, nil // nolint
}
return p.parseIdent()
Expand Down Expand Up @@ -211,6 +211,17 @@ func (p *Parser) parseNumber(pos Pos) (*NumberLiteral, error) {
lastToken, err = p.consumeTokenKind(TokenInt)
case p.matchTokenKind(TokenFloat):
lastToken, err = p.consumeTokenKind(TokenFloat)
case p.matchTokenKind(TokenDot):
_ = p.lexer.consumeToken()
lastToken, err = p.consumeTokenKind(TokenInt)
if err != nil {
return nil, err
}
if lastToken.Base != 10 {
return nil, fmt.Errorf("invalid decimal literal: %q", lastToken.String)
}
lastToken.String = "." + lastToken.String
lastToken.Kind = TokenFloat
default:
return nil, fmt.Errorf("expected <int> or <float>, but got %q", p.lastTokenKind())
}
Expand Down
8 changes: 4 additions & 4 deletions parser/parser_table.go
Original file line number Diff line number Diff line change
Expand Up @@ -223,14 +223,14 @@ func (p *Parser) parseIdentOrFunction(_ Pos) (Expr, error) {
}, nil
}
return funcExpr, nil
case p.tryConsumeTokenKind(".") != nil:
case p.tryConsumeTokenKind(TokenDot) != nil:
switch {
case p.matchTokenKind(TokenIdent):
nextIdent, err := p.parseIdent()
if err != nil {
return nil, err
}
if p.tryConsumeTokenKind(".") != nil {
if p.tryConsumeTokenKind(TokenDot) != nil {
thirdIdent, err := p.parseIdent()
if err != nil {
return nil, err
Expand Down Expand Up @@ -310,7 +310,7 @@ func (p *Parser) parseTableSchemaClause(pos Pos) (*TableSchemaClause, error) {
return nil, err
}
switch {
case p.matchTokenKind("."):
case p.matchTokenKind(TokenDot):
// it's a database.table
dotIdent, err := p.tryParseDotIdent(p.Pos())
if err != nil {
Expand Down Expand Up @@ -489,7 +489,7 @@ func (p *Parser) parseTableArgExpr(pos Pos) (Expr, error) {
}
switch {
// nest identifier
case p.matchTokenKind("."):
case p.matchTokenKind(TokenDot):
dotIdent, err := p.tryParseDotIdent(p.Pos())
if err != nil {
return nil, err
Expand Down
6 changes: 6 additions & 0 deletions parser/testdata/query/access_tuple_with_dot.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
SELECT tuple('a','b','c').3, .1234;

SELECT toTypeName( tuple('a' as first,'b' as second ,'c' as third)::Tuple(first String,second String,third String)),
(tuple('a' as first,'b' as second ,'c' as third)::Tuple(first String,second String,third String)).second,
tuple('a','b','c').3,
tupleElement(tuple('a','b','c'),1)
11 changes: 11 additions & 0 deletions parser/testdata/query/format/access_tuple_with_dot.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
-- Origin SQL:
SELECT tuple('a','b','c').3, .1234;

SELECT toTypeName( tuple('a' as first,'b' as second ,'c' as third)::Tuple(first String,second String,third String)),
(tuple('a' as first,'b' as second ,'c' as third)::Tuple(first String,second String,third String)).second,
tuple('a','b','c').3,
tupleElement(tuple('a','b','c'),1)

-- Format SQL:
SELECT tuple('a', 'b', 'c').3, .1234;
SELECT toTypeName(tuple('a' AS first, 'b' AS second, 'c' AS third)::Tuple(first String, second String, third String)), (tuple('a' AS first, 'b' AS second, 'c' AS third)::Tuple(first String, second String, third String)).second, tuple('a', 'b', 'c').3, tupleElement(tuple('a', 'b', 'c'), 1);
Loading
Loading