Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add Support for setting SSEA name #296

Merged
merged 10 commits into from
Jan 17, 2024
Merged

Conversation

ampem
Copy link
Contributor

@ampem ampem commented Aug 4, 2023

This change adds support for S3 buckets enforcing Server Side Encryption.

  • The feature is enabled if the config String aws.s3.ssea.name is set
    • valid values are AES256 and aws:kms but this not enforced in the AWS SDK

@ampem ampem closed this Jan 11, 2024
@ampem ampem force-pushed the ssea-name-enablement branch from 48c6502 to e4b3de3 Compare January 11, 2024 15:47
@ampem ampem reopened this Jan 11, 2024
@ampem ampem requested review from a team as code owners January 11, 2024 16:55
@jeqo jeqo self-assigned this Jan 12, 2024
Copy link
Contributor

@jeqo jeqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ampem! I think this is a valid addition to the configs.

Added some comments.

Some chores:

  • Run ./gradlew checkstyleMain checkstyleTest

To fix style related issues

@ampem
Copy link
Contributor Author

ampem commented Jan 16, 2024

Thank you for your feedback @jeqo. Let me know we require any other changes.

@ampem
Copy link
Contributor Author

ampem commented Jan 17, 2024

@jeqo feedback addressed, thanks.

jeqo
jeqo previously approved these changes Jan 17, 2024
Copy link
Contributor

@jeqo jeqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ampem!
LGTM, just left a minor comment to fix format.

@ampem
Copy link
Contributor Author

ampem commented Jan 17, 2024

Thanks, @ampem! LGTM, just left a minor comment to fix format.

Updated, but approval was lost.

@jeqo jeqo merged commit 06f1bb9 into Aiven-Open:main Jan 17, 2024
4 checks passed
@ampem ampem deleted the ssea-name-enablement branch May 27, 2024 18:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants