This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48c6502
to
e4b3de3
Compare
jeqo
suggested changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ampem! I think this is a valid addition to the configs.
Added some comments.
Some chores:
- Run
./gradlew checkstyleMain checkstyleTest
To fix style related issues
src/main/java/io/aiven/kafka/connect/s3/config/S3SinkConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/s3/config/S3SinkConfig.java
Outdated
Show resolved
Hide resolved
src/test/java/io/aiven/kafka/connect/s3/S3OutputStreamTest.java
Outdated
Show resolved
Hide resolved
Thank you for your feedback @jeqo. Let me know we require any other changes. |
jeqo
reviewed
Jan 16, 2024
src/test/java/io/aiven/kafka/connect/s3/S3OutputStreamTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jorge Esteban Quilcate Otoya <[email protected]>
@jeqo feedback addressed, thanks. |
jeqo
reviewed
Jan 17, 2024
jeqo
previously approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ampem!
LGTM, just left a minor comment to fix format.
Updated, but approval was lost. |
jeqo
approved these changes
Jan 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for S3 buckets enforcing Server Side Encryption.
aws.s3.ssea.name
is setAES256
andaws:kms
but this not enforced in the AWS SDK