Override this.props with custom props if prop value is equal to defau… #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I had an issue with this code
const globalTextProps = { allowFontScaling: false, }; setCustomText(globalTextProps);
allowFontScaling is a default prop on Text component, the current implementation do not allow a custom value if a default value is defined on the component.
for each custom prop, I now compare the current value with the default value and use the custom prop if it's equal