feat(ipfs): improve avatar url resolution with content validation #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation Improve the `checkIpfsAvailability` utility to properly verify image content types from IPFS sources. The enhanced function now checks content types from both gateways, handles JSON metadata by extracting embedded image URLs, and properly verifies that returned URLs point to image resources only. This makes the IPFS handling more robust by ensuring we only return valid image URLs and properly handle metadata files that contain references to image assets.
Configure Vitest testing setup for the React package with Node.js environment and create comprehensive test coverage for the `checkIpfsAvailability` utility. The tests cover various IPFS content scenarios including image type verification, JSON metadata handling, and fallback behavior.
pbennett
reviewed
May 19, 2025
| } | ||
|
|
||
| const cid = url.replace('ipfs://', '') | ||
| const nfdUrl = `https://images.nf.domains/ipfs/${cid}` |
There was a problem hiding this comment.
we'll need to point to something else in the future but definitely fine for now.
pbennett
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the IPFS utility to properly resolve NFD avatar URLs into browser-displayable HTTPS links. It adds robust content validation to ensure the resolved URLs point to actual images, with special handling for NFT-style JSON metadata that may contain nested image references.
Details