webpack 4 compatability - fix - no need for async

Algotec · Sep 25, 2018 · 7af3878 · 7af3878
1 parent ad8f3b8
commit 7af3878
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/lib/html-elements-webpack-plugin.js b/lib/html-elements-webpack-plugin.js
@@ -23,7 +23,7 @@ class HtmlElementsWebpackPlugin {
 			(compilation) => {
 				compilation.options.htmlElements = compilation.options.htmlElements || {};
 				compatAddPlugin(compilation, 'html-webpack-plugin-before-html-generation',
-					(htmlPluginData, callback) => {
+					(htmlPluginData) => {
 						const locations = this.locations;
 						if (locations) {
 							const publicPath = htmlPluginData.assets.publicPath;
@@ -32,10 +32,7 @@ class HtmlElementsWebpackPlugin {
 								compilation.options.htmlElements[loc] = getHtmlElementString(locations[loc], publicPath);
 							});
 						}
-
-						if (typeof callback === 'function')
-							callback(null, htmlPluginData);
-					}, true);
+					});
 			});
 	}
 }