Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various issues #33

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Fix various issues #33

merged 4 commits into from
Oct 4, 2024

Conversation

Amanieu
Copy link
Owner

@Amanieu Amanieu commented Sep 18, 2024

This fixes several issues, in particular:

  • x86 Windows was crashing in the trap handler test because the SEH exception chain wasn't being reset properly.
  • Inline assembly was using 0: and 1: labels which cause issues and are linted against.
  • Fix some compilation warnings.
  • Disabled the asm-unwind feature in CI. It seems to currently be broken due to LLVM issues.

Fixes #31

This avoids errors due to a new lint added to rustc.
This was previously causing issues when the exception catcher was
inlined into the root handler function.
This is currently broken due to LLVM generating incorrect code.
@Amanieu Amanieu changed the title Fix inline assembly labels on x86 Fix various issues Oct 4, 2024
@Amanieu Amanieu merged commit f9c9833 into master Oct 4, 2024
24 checks passed
@Amanieu Amanieu deleted the fix-labels branch October 4, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile fail in some arch
1 participant