SLB-267: Persisted query cache corruption #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dspachos
force-pushed
the
hotfix/SLB-267-persistent-query-internal-page-cache-issue
branch
from
a1d9dd2 to
fcd09ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where a persisted query suddenly returned the result of a different query. Both queries involved used exactly the same parameters, and changing a parameter in one of them fixed the issue. This suggests that the page cache metadata in persisted queries only includes the variables, but not the query id.
A proper fix (with tests included) is coming for the contributed graphql module.