Dummy adapter #53
Milestone
Comments
This was referenced Jun 4, 2019
Closed
Merged
Closed
|
Currently implemented:
Note: They are Future based! 🎉 To be implemented, once we have the overview what would be the structure:
MerkleTree: |
elpiel
added a commit
that referenced
this issue
Jun 10, 2019
* Workspace - add `Adapter` crate * domain - validator - make `fixtures` module `pub`, instead of `pub(crate)` * adapter - Cargo.toml - add `domain` to deps and enable `fixtures` feature for dev. dep. * adapter - lib - start impl SanityChecker & add simple trait Adapter * adapter - separate SanityChecker, Adapter and add a feature for DummyAdapter * adapter - Cargo.toml - add the `dummy-adapter` feature * domain - channel - impl SpecValidators, as we need to handle only a leader and a follower inside * adapter - sanity - simplify the check if the adapter exists in the channel validators * Makefile - add `tasks.clippy` to `dev-test-flow` after `rustfmt` for Dev env. * `Clippy` warnings fix - take `&str` instead of `&String` * Clippy: - domina/sentry/adapter - add `deny(clippy::all)` - adapter - add `deny(rust_2018_idioms)` * adapter - `Adapter::whoami()` use `&str` instead of `&String` * domain - channel - fixtures - valid_until should always be in the future * adapter - Cargo.toml - add `chrono` and `time` * domain - Asset - derive `PartialEq` & `Eq` * domain - BigNum - impl `Add` & `Sub` * adapter - Config and ConfigBuilder * [+test] adapter - sanity - impl all the validation checks * [test] adapter - sanity - fix minimum fee test * domain - validator - fixtures - optional `fee` argument * [test] adapter - sanity - SanityCheck correct channel validation test * run `rustfmt` * adapter - Cargo.toml - add `hex` * adapter - add `sign` & `verify` + impl dummy `sign` & `verify` * [+test] adapter - dummy - `sign` & `verify` docs-tests + a unit test * adapter - Adapter - `get_auth` method: - Adapter - AdapterError - dummy - DummyParticipant - dummy - Dummy - use `HashSet` and store the dummy participants - dummy - Dummy - use participants for the `get_auth` method * [+test] adapter - DummyAdapter - fix implementation of `get_auth` * adapter - DummyAdapter - move the success `get_auth` call to doc-test * adapter - add doc-test attribute to enable the `dummy-adapter` feature * adapter - dummy - why does CI fails :( * adapter - add `futures-preview` * adapter - enable `async_await` & await_macro` features + add them to the doc-tests as well * adapter - `sign`, `verify` & `validate_channel` to `Future` based * adapter - `get_auth` to `Future` based * Makefile.toml - Use the new env. variable for `clippy` arguments
|
resolved in #143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As part of the Tracking issue #25 for Adapters we need to create a dummy adapter implementation.
Since we are starting to work on the Validator Workers and this is one of the first things that we are going to need to be used in the Validator Worker and eventually in Sentry.
Create an
adaptercrate where we are going to define the traits and later we can implement them in a feature for thedummyand use separateadapter-dummycrate for this.Reference to JS implementation: https://github.com/AdExNetwork/adex-validator/blob/master/adapters/dummy/index.js
The text was updated successfully, but these errors were encountered: