Issue #53 Dummy Adapter #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture for dev. dep.
…eader and a follower inside
Ivshti
requested changes
Jun 4, 2019
adapter/src/sanity.rs
Outdated
| } | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct SanityError {} |
There was a problem hiding this comment.
we may get an anti-ableism PR one day but I'd rather wait for that than to think of another name for it
There was a problem hiding this comment.
Agree, but validator was really not the name... So I went with something for now. It can change, since I am still exploring the domain around the Adapter. This may even disappear at the end, idk yet.
- Adapter - AdapterError - dummy - DummyParticipant - dummy - Dummy - use `HashSet` and store the dummy participants - dummy - Dummy - use participants for the `get_auth` method
elpiel
force-pushed
the
issue-53-dummy-adapter
branch
from
e81ee40 to
f7768b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves to some extend #53
isChannelValidfrom here (js reference) is implemented with theSanityCheckerchannel.spec.withdrawPeriodStart < channel.validUntilwas moved to it's own task in Channel Spec ChannelSpec fields #24TODOs:
Adapter trait: