Mani: QuotifyApp - Remote call #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- lambda func like CopyText & ShareAction events moved into MainEvents
- state passed into screens instead data
- Toast handled with extension func and event
- Remote call implementation
anandwana001
requested changes
Oct 7, 2024
Mani-Quotify/app/build.gradle.kts
Outdated
| @@ -63,6 +63,8 @@ dependencies { | |||
| implementation(libs.androidx.ui.navigation) | |||
| implementation(libs.androidx.room.runtime) | |||
| implementation(libs.androidx.room.ktx) | |||
| implementation(libs.retrofit) | |||
| implementation(libs.converter.gson) | |||
There was a problem hiding this comment.
can we use kotlin serialization?
|
|
||
| import com.mani.quotify007.domain.model.Quote | ||
|
|
||
| val quotesDataList = mutableListOf( |
There was a problem hiding this comment.
do we still need these?
Comment on lines
31
to
39
| viewModel.copyTextEvent.observe(this) { quote -> | ||
| onCopyText(this, quote) | ||
| } | ||
| viewModel.shareClickEvent.observe(this) { quote -> | ||
| shareQuote(this, quote) | ||
| } | ||
| viewModel.showToast.observe(this) { message -> | ||
| message?.let { showToast(it) } | ||
| } |
There was a problem hiding this comment.
more better approach? looks repetative
Comment on lines
23
to
31
| private val _copyTextEvent = MutableLiveData<Quote>() | ||
| val copyTextEvent: LiveData<Quote> = _copyTextEvent | ||
|
|
||
| private val _shareClickEvent = MutableLiveData<Quote>() | ||
| val shareClickEvent: LiveData<Quote> = _shareClickEvent | ||
|
|
||
| private val _showToast = MutableLiveData<String>() | ||
| val showToast: LiveData<String> = _showToast | ||
|
|
There was a problem hiding this comment.
can't we use just MainEvent
There was a problem hiding this comment.
Alos, why livedata, why not stateflow?
-Removed GSON converter -Used Kotlin Serialization -Manual dependency items simplified
|
@anandwana001 Addressed comments, please review. |
…ests and responses
Comment on lines
34
to
37
| _state.value = | ||
| _state.value.copy(favoriteQuotes = quotes) | ||
| _state.value = _state.value.copy( | ||
| quotes = useCase.result().results.map { quote -> |
There was a problem hiding this comment.
why multiple, why not one statement?
|
@anandwana001 Comment addressed. Please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Lambda func like CopyText & ShareAction events moved into MainEvents(Prev MR comment addressed)
State passed into screens instead data(Prev MR comment addressed)
Toast handled with extension func and event
Remote call implementation with retrofit
(Updated)
Removed GSON converter
Kotlin Serialization technique implemented
Manual dependency items simplified
Removed static data list
Handled the repetative livedata approach into sharedflow with Event.
Added Okhttp loggin interceptor for logs of HTTP requests and responses
Checklist
README.mdfile with a brief overview of the project, how to set it up, and any relevant information.Screenshots
Project README
Please ensure that your project's
README.mdis detailed and includes:Additional Notes
Thank you for your contribution!