feat: add emoji generator script #321
Conversation
wax911
changed the title
| LATEST_RELEASE=$(echo "$RELEASE_INFO" | jq -r '.tag_name') | ||
| RELEASE_URL=$(echo "$RELEASE_INFO" | jq -r '.html_url') | ||
| echo "VERSION=$(echo \"$LATEST_RELEASE\" | grep -oP '(?<=emojibase-data@)\d+\.\d+\.\d+')" >> $GITHUB_ENV | ||
| echo "RELEASE_URL=$RELEASE_URL" >> $GITHUB_ENV |
There was a problem hiding this comment.
RELEASE_URL is the latest emoji release, right?
| assert exc_info.value.code is not None | ||
|
|
||
|
|
||
| def test_normalization(): |
There was a problem hiding this comment.
the only thing that i might've added is test for isEmoji for these emojies: https://developer.android.com/develop/ui/views/text-and-emoji/emoji2
🐦🔥 🧑🧑🧒🧒 👩🏽🦽➡️ 🇲🇶
🩷 🫸🏼 🐦⬛
🫠 🫱🏼🫲🏿 🫰🏽
😶🌫️ 🧔🏻♀️ 🧑🏿❤️🧑🏾
🥲 🥷🏿 🐻❄️
🧑🏻🦰 🧑🏿🦯 👩🏻🤝👩🏼
🦩 🦻🏿 👩🏼🤝👩🏻
There was a problem hiding this comment.
Great recommendation, however this would the the wrong place to do this. this script has one major role which is to convert map emojipedia emojis into a simpler structure we can use in the library. However the library already has tests EmojiTest.kt that make use of emoji-test.txt derived from https://www.unicode.org/Public/emoji/latest/emoji-test.txt this would cover the case of validating that all the unicode compliant emojis are catered for.
wax911
force-pushed
the
feat/226-platform-actions-create-automated-action-to-generate-emojijson-inline-with-unicodeorg
branch
from
1dc9f48 to
b25e7bb
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
wax911
deleted the
feat/226-platform-actions-create-automated-action-to-generate-emojijson-inline-with-unicodeorg
branch
AniTrend Pull Request
Thank you for contributing! Please take a moment to review our contributing guidelines to make the process easy and effective for everyone involved.
Please open an issue before embarking on any significant pull request, especially those that add a new library or change existing tests, otherwise you risk spending a lot of time working on something that might not end up being merged into the project.
Before opening a pull request, please ensure you've done the following:
developand targetsdevelop(where applicable)Description
See: #226
Types of changes
IMPORTANT: By submitting a patch, you agree to allow the project owners to license your work under the terms of the Apache License 2.0.