⚡ Bolt: [performance improvement] Throttle Navbar Scroll Event#82
⚡ Bolt: [performance improvement] Throttle Navbar Scroll Event#82Animesh-jsx wants to merge 1 commit into
Conversation
…onFrame
- Added requestAnimationFrame throttling to handleScroll
- Marked window scroll event listener as { passive: true }
- Ensured cleanup avoids memory leaks using cancelAnimationFrame
Co-authored-by: Animesh-jsx <159705118+Animesh-jsx@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: The global window scroll event listener in
Navbar.tsxhas been optimized. ThesetScrolledstate update is now throttled usingrequestAnimationFrame, and the event listener itself is marked{ passive: true }.🎯 Why: To prevent the
scrollevent from blocking the main thread and forcing synchronous layout recalculations (layout thrashing) on high-frequency scroll events, improving the UI frames-per-second consistency.📊 Impact: Significantly reduces React state updates and main-thread processing per scroll cycle, lowering JS execution time on scroll.
🔬 Measurement: Verify by scrolling rapidly down the page. The scroll should feel smooth without any dropped frames or jank, and the navbar style transition to
glass-panelwill still correctly apply when scrolling past the 20px threshold.PR created automatically by Jules for task 14263338201066796121 started by @Animesh-jsx