Skip to content

Remove filter as test which is going to be deprecated#86

Open
jordiclariana wants to merge 1 commit intoAnsibleShipyard:masterfrom
StuartApp:ansible26-deprecations
Open

Remove filter as test which is going to be deprecated#86
jordiclariana wants to merge 1 commit intoAnsibleShipyard:masterfrom
StuartApp:ansible26-deprecations

Conversation

@jordiclariana
Copy link
Copy Markdown

@jordiclariana jordiclariana commented Jul 31, 2018

With Ansible 2.6 this warning is shown:

[DEPRECATION WARNING]: Using tests as filters is deprecated. Instead of using `result|version_compare` use `result 
is version_compare`. This feature will be removed in version 2.9. Deprecation warnings can be disabled by setting 
deprecation_warnings=False in ansible.cfg.

This PR fixes this.

@ernestas-poskus
Copy link
Copy Markdown
Member

Then we will have to bump required Ansible version https://github.com/AnsibleShipyard/ansible-zookeeper/blob/master/meta/main.yml#L7

@jordiclariana
Copy link
Copy Markdown
Author

I don't think that is necessary. I made this change here too and I checked against Ansible 2.2 and it worked perfectly, so I think is safe to say it is backwards compatible until Ansible 2.2 at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants