[1.1.0] disable boringssl debug symbols on release builds; restore reproducible builds in CI #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
commented
Feb 13, 2025
| @@ -3,6 +3,13 @@ target_compile_options(fipsmodule PRIVATE -Wno-error) | |||
| target_compile_options(crypto PRIVATE -Wno-error) | |||
| target_compile_options(decrepit PRIVATE -Wno-error) | |||
|
|
|||
| # boringssl's forced-on debug symbols interfere with reproducibility due to path differences; disable on Release builds | |||
| if(CMAKE_BUILD_TYPE STREQUAL "Release") | |||
There was a problem hiding this comment.
Checking CMAKE_BUILD_TYPE like this isn't ideal at all and maybe even borderline anti-pattern. But I'm not really sure what other indicator to use of "no thanks I don't want debug symbols"
heifner
approved these changes
Feb 13, 2025
greg7mdp
approved these changes
Feb 13, 2025
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boringssl's upstream cmake file always adds
-ggdbto the compile which damages our reproducibility due to a path difference. We might want to rectify the path difference if possible and/or masquerade the difference via compiler options, but disabling the debug symbol generation is far easier by negating the-ggdbwith-g0