Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a warning of comparison of integer expressions of different signedness in nonprune_to_prune_on_start test #1190

Closed
wants to merge 1 commit into from
Closed

Fix a warning of comparison of integer expressions of different signedness in nonprune_to_prune_on_start test #1190

wants to merge 1 commit into from

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Feb 20, 2025 •
edited
Loading

Fix

tests/block_log.cpp:655:26: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Wsign-compare]
  655 |    for(unsigned i = 0; i < prune_blocks*3; ++i)

@spoonincode
Copy link
Member

could consider taking it back to 1.1.1

@linh2931
Copy link
Member Author

could consider taking it back to 1.1.1

Good idea. It is low risk and makes compile cleaner on both branches. Will close this PR and start from release/1.1 branch. Will create a small issue as it makes changes on release/1.1 branch.

@linh2931 linh2931 closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@spoonincode spoonincode spoonincode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linh2931 @spoonincode @heifner