Skip to content

Update logging.json GELF example #1402

Merged
heifner merged 3 commits into
mainfrom
logging-gelf-example
Apr 18, 2025
Merged

Update logging.json GELF example #1402
heifner merged 3 commits into
mainfrom
logging-gelf-example

Conversation

@heifner

@heifner heifner commented Apr 18, 2025

Copy link
Copy Markdown
Contributor

Change the example logging.json to have a GELF endpoint that doesn't resolve so that a GELF thread is not created and does not continuously try to send log messages.

Also improve the error message when unable to connect to configured GELF endpoint.

@heifner heifner added the OCI Work exclusive to OCI team label Apr 18, 2025
@heifner heifner added this to the Spring v1.2.0-rc1 milestone Apr 18, 2025
@heifner heifner requested review from greg7mdp and spoonincode April 18, 2025 14:43
Comment thread programs/nodeos/logging.json Outdated
"type": "gelf",
"args": {
"endpoint": "10.10.10.10:12201",
"endpoint": "my_server.example.com:12201",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could resolve somewhere though, better to use something like my_server.example.invalid or my_server.example since these two TLD domains (along with a couple others) are prohibited from ever being used.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm outdated, example.com is reserved now too, so nevermind

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is reserved to actually work. Seems like "my_server" will not be provided. But I do think my_server.example.invalid is better because we want an error. The .invalid is defined to not resolve.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right yeah that's the difference I'm thinking of -- foo.example.com successfully resolves to no results, where as foo.example fails to resolve

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@heifner heifner merged commit dcd0ee9 into main Apr 18, 2025
@heifner heifner deleted the logging-gelf-example branch April 18, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCI Work exclusive to OCI team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants