Update logging.json GELF example #1402
Conversation
…example logging.json creating a GELF thread that keeps sending.
| "type": "gelf", | ||
| "args": { | ||
| "endpoint": "10.10.10.10:12201", | ||
| "endpoint": "my_server.example.com:12201", |
There was a problem hiding this comment.
That could resolve somewhere though, better to use something like my_server.example.invalid or my_server.example since these two TLD domains (along with a couple others) are prohibited from ever being used.
There was a problem hiding this comment.
Sorry I'm outdated, example.com is reserved now too, so nevermind
There was a problem hiding this comment.
It is reserved to actually work. Seems like "my_server" will not be provided. But I do think my_server.example.invalid is better because we want an error. The .invalid is defined to not resolve.
There was a problem hiding this comment.
Right yeah that's the difference I'm thinking of -- foo.example.com successfully resolves to no results, where as foo.example fails to resolve
Change the example
logging.jsonto have a GELF endpoint that doesn't resolve so that a GELF thread is not created and does not continuously try to send log messages.Also improve the error message when unable to connect to configured GELF endpoint.