-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue when contracts w/o source IDs would not enrich #2047
Merged
+247
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
previously approved these changes
May 1, 2024
inputs should work! but it looks like it is struggling to find the In [3]: contr = Contract("0x3fC91A3afd70395Cd496C647d5a6CC9D4B2b7FAD")
In [4]: [err.name for err in contr.contract_type.errors]
Out[4]:
['BalanceTooLow',
'BuyPunkFailed',
'ContractLocked',
'ETHNotAccepted',
'ExecutionFailed',
'FromAddressIsNotOwner',
'InsufficientETH',
'InsufficientToken',
'InvalidBips',
'InvalidCommandType',
'InvalidOwnerERC1155',
'InvalidOwnerERC721',
'InvalidPath',
'InvalidReserves',
'InvalidSpender',
'LengthMismatch',
'SliceOutOfBounds',
'TransactionDeadlinePassed',
'UnableToClaim',
'UnsafeCast',
'V2InvalidPath',
'V2TooLittleReceived',
'V2TooMuchRequested',
'V3InvalidAmountOut',
'V3InvalidCaller',
'V3InvalidSwap',
'V3TooLittleReceived',
'V3TooMuchRequested']
In [5]: EDIT: fixed! Had to search from the back 95d5d39 |
fubuloubu
previously approved these changes
May 2, 2024
7eee9c6
to
ac25fa4
Compare
antazoey
commented
May 2, 2024
|
fubuloubu
previously approved these changes
May 2, 2024
daa4dee
to
b9f26da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: #2035
Enrichment was skipped for contracts missing source IDs. This adds it.
bonuses that are not needed but were still part of the fun:
312
black value and useelif
in a spot ape-solidity#141TODO: Refactor CompilerAPI plugins to use new helper method (instead of re-implementing n-places)
compiler_manager.get_custom_error()
How I did it
How to verify it
Checklist