Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include additional flags to ape networks run #2482

Merged
merged 7 commits into from
Jan 31, 2025

Conversation

0xthedance
Copy link
Contributor

@0xthedance 0xthedance commented Jan 28, 2025

What I did

Allows passing additional flag to the command ape networks run', such as --block-time` .

fixes: #1672

Checklist

  • All changes are completed
  • Change is covered in tests
  • Documentation is complete

fubuloubu
fubuloubu previously approved these changes Jan 28, 2025
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Looking good, what level of testing have you done with it so far?

I think if we can test with a few different providers, we would be good to go on this

@antazoey
Copy link
Member

I got the flakey test fixed on another PR.
Consider adding integration tests next to the others in tests/integration/cli/test_networks.py, they don't have to do much, besides ensure you can pass in values for these.

@antazoey
Copy link
Member

does setting --block-time actually set the value in anvil to? that's neat!

@0xthedance
Copy link
Contributor Author

Actually, it didn't do it. But I've fixed it, and now it does configure the block-time for Anvil.I'm not sure about the local Geth. I think it doesn't allow you to configure the block-time.

@antazoey
Copy link
Member

failing test solved by #2484

@antazoey
Copy link
Member

I'm not sure about the local Geth. I think it doesn't allow you to configure the block-time.

I added a way here: https://github.com/ApeWorX/ape/pull/2487/files
So it will work after this

@antazoey antazoey merged commit adc0458 into ApeWorX:main Jan 31, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing additional flags to ape networks run [APE-1410]
3 participants