Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for box.lsp before applying languageserver options #618

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Add check for box.lsp before applying languageserver options #618

merged 1 commit into from
Sep 18, 2024

Conversation

radbasa
Copy link
Contributor

@radbasa radbasa commented Sep 18, 2024

Related to Appsilon/box.lsp#28

Description

  • A rhino app project should now run CI without fail.

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

@jakubnowicki jakubnowicki merged commit dc9c08b into main Sep 18, 2024
10 checks passed
@jakubnowicki jakubnowicki deleted the bugfix/box-lsp-ci-failing-bug branch September 18, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubnowicki jakubnowicki jakubnowicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radbasa @jakubnowicki