Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved docker documentation for first time users #89

Merged
merged 1 commit into from
Sep 5, 2024
Merged

improved docker documentation for first time users #89

merged 1 commit into from
Sep 5, 2024

Conversation

bryanpedini
Copy link
Contributor

as per the title, I improved a bit the documentation for docker user, explaining how to get the config file to avoid the following error at startup if launched with an empty config file

Application booted at Thu, 05 Sep 2024 14:16:09 GMT
file:///usr/src/app/src/index.mjs:22
Object.keys(config.repositories.github).forEach((type) => {
                                ^

TypeError: Cannot read properties of undefined (reading 'github')
    at file:///usr/src/app/src/index.mjs:22:33
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:527:24)
    at async loadESM (node:internal/process/esm_loader:91:5)
    at async handleMainPromise (node:internal/modules/run_main:65:12)

Node.js v18.9.1

or the following if launched without a file present at /usr/src/app/etc/config.js at all

Application booted at Thu, 05 Sep 2024 14:16:36 GMT
file:///usr/src/app/src/index.mjs:22
Object.keys(config.repositories.github).forEach((type) => {
                                ^

TypeError: Cannot read properties of undefined (reading 'github')
    at file:///usr/src/app/src/index.mjs:22:33
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:527:24)
    at async loadESM (node:internal/process/esm_loader:91:5)
    at async handleMainPromise (node:internal/modules/run_main:65:12)

Node.js v18.9.1

@Ardakilic Ardakilic merged commit 877fa4f into Ardakilic:master Sep 5, 2024
1 check passed
@Ardakilic
Copy link
Owner

Hello, highly appreciate your contribution on this.

@bryanpedini
Copy link
Contributor Author

wym fixing my mistake I noticed in the example? it would be ... cat /usr/src/app/etc/config.example.js > ... instead, I forgot the .example part

Ardakilic added a commit that referenced this pull request Sep 6, 2024
@Ardakilic
Copy link
Owner

Thanks, no worries, this commit should address it: 1e4fa91

Apologies nowadays I'm bloated with work stuff, so I cannot focus on my hobby projects much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants