Add MAVFTP parameter and mission support#1332
Draft
RyanCraighead wants to merge 1 commit into
Draft
Conversation
Adds a MAVFTP client for ArduPilot virtual file transfers. Downloads packed parameters, uploads changed parameters through @PARAM/param.pck from the existing Write path, and uploads/downloads missions through @MISSION/mission.dat, with fallback to existing MAVLink protocols. Adds focused CMake unit coverage for packed parameter files, parameter upload encoding, mission.dat files, and MAVFTP request/response payloads. Relates ArduPilot#1252
1c45a8d to
627785c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FILE_TRANSFER_PROTOCOL.@PARAM/param.pck?withdefaults=1and parses the packed parameter file into the existing parameter update path.@PARAM/param.pckfrom the existing Write (ROM) path, matching ArduPilot's save-on-close behavior for parameter FTP uploads.@MISSION/mission.datusing ArduPilot'sMISSION_ITEM_INTfile format.Validation
git diff --check origin/master..HEAD.mavftp_unit_testscovering packed parameter parsing, parameter upload encoding, mission.dat parsing/writing, malformed file rejection, MAVFTP opcodes/offsets, ACK/NAK/EOF handling, sequence wrap, and payload-size limits.@PARAM/param.pck,@MISSION/mission.dat, and MAVFTP response handling.ctestpassed on the fork validation branch: https://github.com/RyanCraighead/apm_planner/actions/runs/25715278364. The final PR branch excludes the temporary validation workflow.Relates #1252
Transparent note: this implementation was assisted by OpenAI Codex.