-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(world-cli): Add commands for running evm and da layer #17
Merged
jerargus
merged 6 commits into
main
from
jer/world-505-limited-add-evm-and-celestia-devnet-start-to-world-cli
Dec 1, 2023
Merged
feat(world-cli): Add commands for running evm and da layer #17
jerargus
merged 6 commits into
main
from
jer/world-505-limited-add-evm-and-celestia-devnet-start-to-world-cli
Dec 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 57.14% 61.29% +4.14%
==========================================
Files 4 4
Lines 105 124 +19
==========================================
+ Hits 60 76 +16
- Misses 43 45 +2
- Partials 2 3 +1 ☔ View full report in Codecov by Sentry. |
smsunarto
reviewed
Nov 30, 2023
…evnet-start-to-world-cli
…om a locally running docker container
technicallyty
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #WORLD-505
What is the purpose of the change
Add commands to start and stop evm and da layer containers.
To start the evm for prod (this will fail to start if some config variables are missing):
To start evm in dev mode (A da layer container will be started and appropriate env variables will be injected into the config)
To stop the evm and da layers:
Testing and Verifying
I ran manual tests locally after cloning the starter game template.
The current state of starter-game-template has an incorrect negative block time. It's fixed with this PR: Argus-Labs/starter-game-template#32