Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netbox 4 compatibility #165

Merged
merged 21 commits into from
May 9, 2024
Merged

Netbox 4 compatibility #165

merged 21 commits into from
May 9, 2024

Conversation

matejv
Copy link
Member

@matejv matejv commented May 7, 2024

List of items from official plugin porting guide:

General
    ✅ Python support
    ✅ Plugin resources relocated
    ☑️ ContentType renamed to ObjectType (I think I fixed those that need to be fixed)
Views
    🟡 View actions must be dictionaries (not in use) 
Forms
    ✅ Remove BootstrapMixin
    ✅ Update Fieldset definitions
Navigation
    ✅ Remove button colors
UI Layout
    ✅ Renamed template blocks
    🟡 Utilize flex controls (not in use)
    🟡 Check column offsets (not in use)
    ✅ Tables inside cards
    ✅ Remove btn-sm class from buttons
    ✅ Update bg-$color classes
    🟡 Obsolete custom CSS classes (not in use)
REST API
    ✅ Extend serializer for brief mode
    ✅ Include description fields in brief mode
GraphQL
    Change schema.py
    Change types.py
    Change filters.py

Other stuff:

✅ count_related moved
asset_edit template - check
check all other complex templates
✅ The annotated_date template filter and annotated_now template tag have been removed.
✅ move all nested table action buttons from footer to header
✅ change how htmx tables are rendered (new macro) 
on custom tabs for core objects (tabs folder), fix controls button layout
✅ update warranty progress bar component
update render_table to htmx
investigate image attachments includes if it's possible to hide object type & parent columns

@matejv matejv self-assigned this May 7, 2024
@matejv
Copy link
Member Author

matejv commented May 7, 2024

Test should pass and basic functionality should work.

Still need to check and update a bunch of templates and other minor stuff...

@matejv
Copy link
Member Author

matejv commented May 9, 2024

A few issues I identified and not yet fixed are ether netbox bugs, bugs from existing version of the plugin (and are not straightforward to fix) or other small issues that can wait a bit.

@matejv matejv merged commit c1ad26d into master May 9, 2024
1 check passed
@matejv matejv deleted the netbox4 branch May 9, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant