Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypter test #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

makiam
Copy link
Contributor

@makiam makiam commented Jan 7, 2022

No description provided.

@Sailsman63
Copy link
Member

Questions:

  • What are the requirements/limits for a valid secret string?
  • What are the requirements/limits for a valid passphrase?
  • What should be the behavior if an invalid value is passed for either?

@makiam
Copy link
Contributor Author

makiam commented Jan 22, 2022

Only passphrase string should not be null. This gives NPE at Encrypter constructor. All other seems to be valid.
Encoder decoder will return null on some exceptional occurs inside.

@Sailsman63
Copy link
Member

  • Does that mean that all unicode characters are accepted? Or only ASCII? Other?
  • What happens if the passphrase is an empty string? ("")

@makiam
Copy link
Contributor Author

makiam commented Jan 22, 2022

I try to pass to encrypter/decripter some chinese words and it encodes and decodes back ok.
Once I pass empty string as passPhrase tests works ok too.
I cannot say how this is correct from security POV but tests works the same way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants