Spm typed members #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added @OVERRIDES Converted to shorter lambda-style calls for functional interfaces
Sailsman63
force-pushed
the
spm-typed-members
branch
from
bf8f482 to
d69da23
Compare
|
Good changes. For future reference: It would be simpler/easier to review if commits in a PR are arranged thematically, instead of strictly by file. The current commits are what I got after rebaseing to break up the changes by type/intent. |
Sailsman63
reviewed
Feb 28, 2022
Comment on lines
+194
to
+195
| SPMObjectInfo localinfo = manageSplitPane.getFileSystem().getPlugins().stream().filter(self).findFirst().orElse(null); | ||
| SPMObjectInfo remoteinfo = updateSplitPane.getFileSystem().getPlugins().stream().filter(self).findFirst().orElse(null); |
There was a problem hiding this comment.
These lines are far too long. They should be wrapped. Probably align the .stream() with .getPlugins()
|
Which types of warnings? Please break them up. Also, please don't merge the main branch into a pr like this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.