Rxy + ghost note inaccuracies #22
Comments
|
Here is the test case which I think highlights what @rasky is talking about: RxxTest.zip. Here's some audio comparisons. This is a diff of FT2Clone (Dark) and LibXM (Light):
Here's the full comparison image, which highlights that MilkyTracker and OpenMPT fail this as well:
The test case is is actually just parts taken from look & zalza - little computer boy. |
Nobody was resetting autovibrato_note_offset after instrument change. The fact that xm_autovibrato doesn't update it each tick is not sufficient: all future xm_update_frequency() in this channel will still take into account the current autovibrato offset. Instead of trying to reset autovibrato_note_offset when the instrument does change (considering that we might even have to rework instrument changing logic -- see Artefact2#22), I made xm_autovibrato reset it when it is not needed anymore. This keeps the logic updating autovibrato_note_offset all in the same function. Co-developed with @bryc who also prepared the testcase.
|
Hi @jmorel33, the licensing is not clear on your modified file so I can't merge any changes back in libxm (which is WTFPLv2) as is. Stereo samples are not standard (and in my experience not a widely used feature) so I think it's out of scope for libxm (unless you have good examples of XMs with stereo samples). If you could submit playback fixes as patches or pull requests (ideally with a test case), that would be much better licensing-wise. Thanks! |
FT2 and IT never officially supported stereo samples at all, so I'd hold back on writing that memoir. It was the Modplug Tracker (now OpenMPT) that added stereo support to XM, IT. |
|
cheers. And good luck. |
|
Maybe this can help. |
Just to log it, there's another bug in Rxy which I'm not planning to fix for now. If a row contains no note but an instrument with the Rxy effect, what happens is that on tick 0, the ghost note of the previous instrument plays (as per standard behavior with rows that contain instruments without notes), but on the first retrigger the instrument is changed to the new one. So actually the instrument changes mid-row.
This looks harder to implement because the logic to change instruments is not part of
xm_trigger_note, but I haven't investigated into it. If you want, I can open an issue to log this.Originally posted by @rasky in #20 (comment)
The text was updated successfully, but these errors were encountered: