Fix autovibrato that is kept on after instrument change. #26
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nobody was resetting autovibrato_note_offset after instrument change. The fact that xm_autovibrato doesn't update it each tick is not sufficient: all future xm_update_frequency() in this channel will still take into account the current autovibrato offset. Instead of trying to reset autovibrato_note_offset when the instrument does change (considering that we might even have to rework instrument changing logic -- see Artefact2#22), I made xm_autovibrato reset it when it is not needed anymore. This keeps the logic updating autovibrato_note_offset all in the same function. Co-developed with @bryc who also prepared the testcase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nobody was resetting autovibrato_note_offset after instrument change.
The fact that xm_autovibrato doesn't update it each tick is not
sufficient: all future xm_update_frequency() in this channel will still
take into account the current autovibrato offset.
Instead of trying to reset autovibrato_note_offset when the instrument
does change (considering that we might even have to rework instrument
changing logic -- see #22), I made xm_autovibrato reset it when it is
not needed anymore. This keeps the logic updating
autovibrato_note_offset all in the same function.
Co-developed with @bryc who also prepared the testcase.