Fix release mode on Windows. (#13)

This resolves: #10 Apparently, cmake on Windows do honor its own "CMAKE_BUILD_TYPE". We need to use "--config Release" to build in release mode.
ArthurSonzogni · Aug 31, 2022 · d51650a · d51650a
1 parent db4310e
commit d51650a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -102,7 +102,7 @@ jobs:
           mkdir build;
           cd build;
           cmake ..  -DCMAKE_BUILD_TYPE=Release;
-          cmake --build . --target package;
+          cmake --build . --target package --config Release
       - uses: shogo82148/actions-upload-release-asset@v1
         with:
           upload_url: ${{ needs.release.outputs.upload_url }}

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,6 @@
 # (head)
 - Update FTXUI version.
+- Fix issue 10: Windows Github Release contains Debug version.
 
 # v1.0.8
 - Support PageDown,PageUp,HomeEnd button.