Merge pull request #141 from rebelinux/dev

Code Cleanup
AsBuiltReport · Feb 2, 2024 · ffe3d2d · ffe3d2d
2 parents 46fa825 + 648dabf
commit ffe3d2d
Show file tree

Hide file tree

Showing 76 changed files with 2,892 additions and 3,477 deletions.
diff --git a/AsBuiltReport.Veeam.VBR.psd1 b/AsBuiltReport.Veeam.VBR.psd1
@@ -8,130 +8,130 @@
 
 @{
 
-# Script module or binary module file associated with this manifest.
-RootModule = 'AsBuiltReport.Veeam.VBR.psm1'
+    # Script module or binary module file associated with this manifest.
+    RootModule = 'AsBuiltReport.Veeam.VBR.psm1'
 
-# Version number of this module.
-ModuleVersion = '0.8.5'
+    # Version number of this module.
+    ModuleVersion = '0.8.5'
 
-# Supported PSEditions
-# CompatiblePSEditions = @()
+    # Supported PSEditions
+    # CompatiblePSEditions = @()
 
-# ID used to uniquely identify this module
-GUID = '7f25f32e-70cb-49e6-a71b-eec42e0595c1'
+    # ID used to uniquely identify this module
+    GUID = '7f25f32e-70cb-49e6-a71b-eec42e0595c1'
 
-# Author of this module
-Author = 'Jonathan Colon'
+    # Author of this module
+    Author = 'Jonathan Colon'
 
-# Company or vendor of this module
-#CompanyName = 'Unknown'
+    # Company or vendor of this module
+    #CompanyName = 'Unknown'
 
-# Copyright statement for this module
-Copyright = '(c) 2024 Jonathan Colon. All rights reserved.'
+    # Copyright statement for this module
+    Copyright = '(c) 2024 Jonathan Colon. All rights reserved.'
 
-# Description of the functionality provided by this module
-Description = 'A PowerShell module to generate an as built report on the configuration of Veeam VBR.'
+    # Description of the functionality provided by this module
+    Description = 'A PowerShell module to generate an as built report on the configuration of Veeam VBR.'
 
-# Minimum version of the Windows PowerShell engine required by this module
-PowerShellVersion = '5.1'
+    # Minimum version of the Windows PowerShell engine required by this module
+    PowerShellVersion = '5.1'
 
-# Name of the Windows PowerShell host required by this module
-# PowerShellHostName = ''
+    # Name of the Windows PowerShell host required by this module
+    # PowerShellHostName = ''
 
-# Minimum version of the Windows PowerShell host required by this module
-# PowerShellHostVersion = ''
+    # Minimum version of the Windows PowerShell host required by this module
+    # PowerShellHostVersion = ''
 
-# Minimum version of Microsoft .NET Framework required by this module. This prerequisite is valid for the PowerShell Desktop edition only.
-# DotNetFrameworkVersion = ''
+    # Minimum version of Microsoft .NET Framework required by this module. This prerequisite is valid for the PowerShell Desktop edition only.
+    # DotNetFrameworkVersion = ''
 
-# Minimum version of the common language runtime (CLR) required by this module. This prerequisite is valid for the PowerShell Desktop edition only.
-# CLRVersion = ''
+    # Minimum version of the common language runtime (CLR) required by this module. This prerequisite is valid for the PowerShell Desktop edition only.
+    # CLRVersion = ''
 
-# Processor architecture (None, X86, Amd64) required by this module
-# ProcessorArchitecture = ''
+    # Processor architecture (None, X86, Amd64) required by this module
+    # ProcessorArchitecture = ''
 
-# Modules that must be imported into the global environment prior to importing this module
+    # Modules that must be imported into the global environment prior to importing this module
 
-RequiredModules = @(
-    @{
-        ModuleName = 'AsBuiltReport.Core';
-        ModuleVersion = '1.3.0'
-    }
-    @{
-        ModuleName = 'PScriboCharts';
-        ModuleVersion = '0.9.0'
-    }
-    @{
-        ModuleName = 'Veeam.Diagrammer';
-        ModuleVersion = '0.5.8'
-    }
-)
+    RequiredModules = @(
+        @{
+            ModuleName = 'AsBuiltReport.Core';
+            ModuleVersion = '1.3.0'
+        }
+        @{
+            ModuleName = 'PScriboCharts';
+            ModuleVersion = '0.9.0'
+        }
+        @{
+            ModuleName = 'Veeam.Diagrammer';
+            ModuleVersion = '0.5.8'
+        }
+    )
 
-# Assemblies that must be loaded prior to importing this module
-# RequiredAssemblies = @()
+    # Assemblies that must be loaded prior to importing this module
+    # RequiredAssemblies = @()
 
-# Script files (.ps1) that are run in the caller's environment prior to importing this module.
-# ScriptsToProcess = @()
+    # Script files (.ps1) that are run in the caller's environment prior to importing this module.
+    # ScriptsToProcess = @()
 
-# Type files (.ps1xml) to be loaded when importing this module
-# TypesToProcess = @()
+    # Type files (.ps1xml) to be loaded when importing this module
+    # TypesToProcess = @()
 
-# Format files (.ps1xml) to be loaded when importing this module
-# FormatsToProcess = @()
+    # Format files (.ps1xml) to be loaded when importing this module
+    # FormatsToProcess = @()
 
-# Modules to import as nested modules of the module specified in RootModule/ModuleToProcess
-# NestedModules = @()
+    # Modules to import as nested modules of the module specified in RootModule/ModuleToProcess
+    # NestedModules = @()
 
-# Functions to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no functions to export.
-FunctionsToExport = @('Invoke-AsBuiltReport.Veeam.VBR')
+    # Functions to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no functions to export.
+    FunctionsToExport = @('Invoke-AsBuiltReport.Veeam.VBR')
 
-# Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
-#CmdletsToExport = '*'
+    # Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
+    #CmdletsToExport = '*'
 
-# Variables to export from this module
-#VariablesToExport = '*'
+    # Variables to export from this module
+    #VariablesToExport = '*'
 
-# Aliases to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no aliases to export.
-#AliasesToExport = '*'
+    # Aliases to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no aliases to export.
+    #AliasesToExport = '*'
 
-# DSC resources to export from this module
-# DscResourcesToExport = @()
+    # DSC resources to export from this module
+    # DscResourcesToExport = @()
 
-# List of all modules packaged with this module
-# ModuleList = @()
+    # List of all modules packaged with this module
+    # ModuleList = @()
 
-# List of all files packaged with this module
-# FileList = @()
+    # List of all files packaged with this module
+    # FileList = @()
 
-# Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell.
-PrivateData = @{
+    # Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell.
+    PrivateData = @{
 
-    PSData = @{
+        PSData = @{
 
-        # Tags applied to this module. These help with module discovery in online galleries.
-        Tags = @('AsBuiltReport', 'Report', 'Veeam', 'VBR', 'Documentation', 'PScribo', 'Windows', 'PSEdition_Desktop', 'PSEdition_Core')
+            # Tags applied to this module. These help with module discovery in online galleries.
+            Tags = @('AsBuiltReport', 'Report', 'Veeam', 'VBR', 'Documentation', 'PScribo', 'Windows', 'PSEdition_Desktop', 'PSEdition_Core')
 
-        # A URL to the license for this module.
-        LicenseUri = 'https://raw.githubusercontent.com/AsBuiltReport/AsBuiltReport.Veeam.VBR/master/LICENSE'
+            # A URL to the license for this module.
+            LicenseUri = 'https://raw.githubusercontent.com/AsBuiltReport/AsBuiltReport.Veeam.VBR/master/LICENSE'
 
-        # A URL to the main website for this project.
-        ProjectUri = 'https://github.com/AsBuiltReport/AsBuiltReport.Veeam.VBR'
+            # A URL to the main website for this project.
+            ProjectUri = 'https://github.com/AsBuiltReport/AsBuiltReport.Veeam.VBR'
 
-        # A URL to an icon representing this module.
-        IconUri = 'https://github.com/AsBuiltReport.png'
+            # A URL to an icon representing this module.
+            IconUri = 'https://github.com/AsBuiltReport.png'
 
-        # ReleaseNotes of this module
-        ReleaseNotes = 'https://github.com/AsBuiltReport/AsBuiltReport.Veeam.VBR/blob/master/CHANGELOG.md'
+            # ReleaseNotes of this module
+            ReleaseNotes = 'https://github.com/AsBuiltReport/AsBuiltReport.Veeam.VBR/blob/master/CHANGELOG.md'
 
-    } # End of PSData hashtable
+        } # End of PSData hashtable
 
-} # End of PrivateData hashtable
+    } # End of PrivateData hashtable
 
-# HelpInfo URI of this module
-# HelpInfoURI = ''
+    # HelpInfo URI of this module
+    # HelpInfoURI = ''
 
-# Default prefix for commands exported from this module. Override the default prefix using Import-Module -Prefix.
-# DefaultCommandPrefix = ''
+    # Default prefix for commands exported from this module. Override the default prefix using Import-Module -Prefix.
+    # DefaultCommandPrefix = ''
 
 }
 

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 - Removed Graphviz install check code. (No need to manually install Graphviz)
+- Code Cleanup
 
 ### Fixed
 

diff --git a/Src/Private/Get-AbrVbrAgentBackupjob.ps1 b/Src/Private/Get-AbrVbrAgentBackupjob.ps1
@@ -6,7 +6,7 @@ function Get-AbrVbrAgentBackupjob {
     .DESCRIPTION
         Documents the configuration of Veeam VBR in Word/HTML/Text formats using PScribo.
     .NOTES
-        Version:        0.8.4
+        Version:        0.8.5
         Author:         Jonathan Colon
         Twitter:        @jcolonfzenpr
         Github:         rebelinux
@@ -21,7 +21,7 @@ function Get-AbrVbrAgentBackupjob {
     )
 
     begin {
-        Write-PscriboMessage "Discovering Veeam VBR Agent Backup jobs information from $System."
+        Write-PScriboMessage "Discovering Veeam VBR Agent Backup jobs information from $System."
     }
 
     process {
@@ -34,17 +34,16 @@ function Get-AbrVbrAgentBackupjob {
                     $OutObj = @()
                     foreach ($ABkjob in $ABkjobs) {
                         try {
-                            Write-PscriboMessage "Discovered $($ABkjob.Name) location."
+                            Write-PScriboMessage "Discovered $($ABkjob.Name) location."
                             $inObj = [ordered] @{
                                 'Name' = $ABkjob.Name
                                 'Type' = $ABkjob.Type
                                 'OS Platform' = $ABkjob.OSPlatform
                                 'Backup Object' = $ABkjob.BackupObject
                             }
                             $OutObj += [pscustomobject]$inobj
-                        }
-                        catch {
-                            Write-PscriboMessage -IsWarning "Agent Backup Jobs $($ABkjob.Name) Section: $($_.Exception.Message)"
+                        } catch {
+                            Write-PScriboMessage -IsWarning "Agent Backup Jobs $($ABkjob.Name) Section: $($_.Exception.Message)"
                         }
                     }
 
@@ -56,12 +55,11 @@ function Get-AbrVbrAgentBackupjob {
                     if ($Report.ShowTableCaptions) {
                         $TableParams['Caption'] = "- $($TableParams.Name)"
                     }
-                    $OutObj | Sort-Object -Property 'Name' |Table @TableParams
+                    $OutObj | Sort-Object -Property 'Name' | Table @TableParams
                 }
             }
-        }
-        catch {
-            Write-PscriboMessage -IsWarning "Agent Backup Jobs Section: $($_.Exception.Message)"
+        } catch {
+            Write-PScriboMessage -IsWarning "Agent Backup Jobs Section: $($_.Exception.Message)"
         }
     }
     end {}